calc: allow to use shortcut ctrl+Enter in comments #10622
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this.map.mention can be unset in particular in calc. Signed-off-by: Méven Car <[email protected]> Change-Id: I8dba5d36f20d6fe3bf0df9b9fa15a98b70b51eaa
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this.map.mention can be unset in particular in calc.
Change-Id: I8dba5d36f20d6fe3bf0df9b9fa15a98b70b51eaa
Summary
In calc > insert a comment > type some text > hit Ctrl+Enter
Expected:
The popup closes, the comment is saved.
Checklist
make prettier-writeand formatted the code.make checkmake runand manually verified that everything looks okay