Misc Cleanup #10602
Open
Misc Cleanup #10602
+73
−119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Ashod
commented
Nov 26, 2024
Ashod
commented
- wsd: remove unused helpers
- wsd: include cleanup
- wsd: string -> string_view
- wsd: remove superfluous const on primitives in declarations
- wsd: test: Use litteral character for readability
These last saw action in 2018. Change-Id: Iea4c2ed3ce0090c58b5efeaf142598f495f8219e Signed-off-by: Ashod Nakashian <[email protected]>
Change-Id: If95009f099d384926c656b8ade031c5a61678f87 Signed-off-by: Ashod Nakashian <[email protected]>
Change-Id: I78ae04103e03229be7b1b4dc9abc42d71b80e507 Signed-off-by: Ashod Nakashian <[email protected]>
And some formatting. Change-Id: I71ace6b25b4c3fb4bedb6709a6c06e5b6c5d51b7 Signed-off-by: Ashod Nakashian <[email protected]>
Change-Id: I3a02c8300219bf0937a9fc6098c07f787a575c70 Signed-off-by: Ashod Nakashian <[email protected]>
Change-Id: Id06d9ce6d1d90a0c0d25ecb33cd087eb6fe035a0 Signed-off-by: Ashod Nakashian <[email protected]>
Invoking 'make' directly causes the following: warning: jobserver unavailable: using -j1. Add '+' to parent make rule Which disables parallel building when we pass a target. So, `make -j8` will do parallel builds, even with 'make' invoked in the Makefile, but `make -j8 check` will issue the warning and disable parallel building. Using $(MAKE) is the recommended way. C.f. https://www.gnu.org/software/make/manual/html_node/Error-Messages.html and https://www.gnu.org/software/make/manual/html_node/MAKE-Variable.html. Change-Id: Ic1a519e72d1f38b9c8ec50f5da7da53fa27de70a Signed-off-by: Ashod Nakashian <[email protected]>
Ashod
force-pushed
the
private/ash/misc
branch
from
45c16bd
to
77f23b4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.