Tile Intersection: Use a Rectangle/AABBox for Tile/TileCombined to reduce complexity #10197
+89
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
October 9, 2024 06:46
Use Rectangle::intersects(..), providing a most efficient branch-less intersection test. This shall be used in TileDesc's intersect methods, replacing the less efficient branching expression. Generation of automatic Rectangle instances is (almost) free. Note: Previous nor this new code checks for int overflows, assuming sane values. Signed-off-by: Sven Göthel <[email protected]> Change-Id: I2d4bbe9956c4d86ec08939992175a25e505a2fa8
…ssion/ClientSession's isTileInsideVisibleArea Previous implementation left out the tile boundaries intersecting with the _clientVisibleArea, which is now fixed. Signed-off-by: Sven Göthel <[email protected]> Change-Id: I2d4bbe9956c4d86ec08939992175a25e505a2fa8
…TileInsideVisibleArea(), reducing complexity in Document::drainQueue Signed-off-by: Sven Göthel <[email protected]> Change-Id: I2d4bbe9956c4d86ec08939992175a25e505a2fa8
5 tasks
|
COOL 24.04 unit tests w/o cypress — FAILURE: unit-wopi-save-on-exit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Tile Intersection: Use a Rectangle/AABBox for Tile/TileCombined to reduce complexity
Use consolidated Rectangle Intersection on ChildSession/ClientSession's isTileInsideVisibleArea
Previous implementation left out the tile boundaries intersecting with the _clientVisibleArea, which is now fixed.
Use an AABBox in TileCombined for ChildSession::isTileInsideVisibleArea(), reducing complexity in Document::drainQueue
Checklist
make prettier-writeand formatted the code.make checkmake runand manually verified that everything looks okay