Update DOM when saving/saved state is interrupted by document modification #10195
+86
−45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ation - Perform DOM operations to handle cases where the document is modified during a saving or saved state. - If modifications occur, the save icon is reverted back to the "modified" state to reflect the updated document status. Signed-off-by: Darshan-upadhyay1110 <[email protected]> Change-Id: I498128b3a3eee70ef638b472a8fda774d7f6ab92
|
Steps to test patch
Normal case: Screencast.from.2024-10-08.21-58-29.webmWhen we do modify in between state change: Screencast.from.2024-10-08.21-59-42.webm |
eszkadev
reviewed
Oct 9, 2024
eszkadev
reviewed
Oct 9, 2024
eszkadev
reviewed
Oct 9, 2024
Minion3665
previously requested changes
Oct 9, 2024
Darshan-upadhyay1110
force-pushed
the
private/darshan/handle-savemodified-case-in-between-save-states
branch
from
6ed761b
to
77a6d12
Compare
…aveState.ts - Moved icon-related methods (rotation, state changes) to a new file `Control.SaveState.ts`. - Replaced repetitive code in `Control.SaveState.ts` with calls to the new icon control methods. - Cleaned up and streamlined logic for managing save state and icon animations. Signed-off-by: Darshan-upadhyay1110 <[email protected]> Change-Id: I5b1d271789ad7f7a900f88ebc1d945948f9fb34c
Darshan-upadhyay1110
force-pushed
the
private/darshan/handle-savemodified-case-in-between-save-states
branch
from
77a6d12
to
416fdde
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change-Id: I498128b3a3eee70ef638b472a8fda774d7f6ab92
Summary
TODO
Checklist
make prettier-writeand formatted the code.make checkmake runand manually verified that everything looks okay