Dump Memory Usage with SIGUSR1 #10182
Open
+89
−37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Ashod
commented
Oct 7, 2024
Ashod
commented
- wsd: avoid unnecessary temporary strings
- wsd: support reading unknown-sized files
- wsd: dump the smaps summary on USR1
caolanm
reviewed
Oct 7, 2024
kit/Kit.cpp
Outdated
|
|
||
| std::string smap; | ||
| if (const ssize_t size = FileUtil::readFile("/proc/self/smaps_rollup", smap); size <= 0) | ||
| oss << "\n smaps_rollup: <unavilable>"; |
There was a problem hiding this comment.
s/unavilable/unavailable FWIW
There was a problem hiding this comment.
I swear it was fixed, evidently in a different branch. Thanks for the catch!
caolanm
reviewed
Oct 7, 2024
caolanm
approved these changes
Oct 7, 2024
Ashod
force-pushed
the
private/ash/misc2
branch
from
0a35011
to
2282766
Compare
|
I wonder - we should prolly also dump the prometheus metrics on USR1 =) that's a nice set of strings that may help us. But quite possibly we should just trigger a callback that does that once at idle in the admin thread: set a global std::atomic and check for & clear it in the idle loop in the admin poll that servers those metrics normally. |
Change-Id: I0cf1c6c7058d518ad134bd8099079f2fc6e22837 Signed-off-by: Ashod Nakashian <[email protected]>
Procfs doesn't report the size of on-demand files (for obvious reasons). This leads to failure to read such files, since stat(2) reports their size as 0. We also refactor the read loop, which retries as necessary, so it can be re-used elsewhere. Change-Id: Ibebb8aa62d39331537199cfddd7ae085824f353b Signed-off-by: Ashod Nakashian <[email protected]>
To get memory statistics, we dump smaps_rollup in dumpState, which is invoked on SIGUSR1. Change-Id: Ic38aa4f265a2b9ccb06eb6c4b6ba3d10b7dc6b7a Signed-off-by: Ashod Nakashian <[email protected]>
Ashod
force-pushed
the
private/ash/misc2
branch
from
2282766
to
d7e1ecf
Compare
Good idea. Done: d7e1ecf |
Change-Id: I51a2dd80bca4aa33a2829f7e8baf87034a654f61 Signed-off-by: Ashod Nakashian <[email protected]>
Ashod
force-pushed
the
private/ash/misc2
branch
from
d7e1ecf
to
7974f9f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.