wip: feat(impress): Add legacy export types #10149
Draft
+35
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch exposes in online some rare export options that are available in core. Notably, one of those "download" options is SVG, which poses a problem for how we currently handle slideshows: we need those not to download. We can mitigate this by using the attachment=0 query parameter for slideshows rather than blocking downloads for all SVGs. TODO: This patch does not include icons for the new export action types. TODO: We need to decide which of these should be on by default, and make it so. TODO: We need to merge core patches so all the downloads we want are available. TODO: We need to figure out if we want .swf, and if so what to do about the coreside (as it was removed from core in the past) TODO: In presentations with videos, there seems to be something calling back to the server you downloaded from in SVG exports... this likely needs to be stripped.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch exposes in online some rare export options that are available in core.
Notably, one of those "download" options is SVG, which poses a problem for how we currently handle slideshows: we need those not to download. We can mitigate this by using the attachment=0 query parameter for slideshows rather than blocking downloads for all SVGs.
TODO: This patch does not include icons for the new export action types.
TODO: We need to decide which of these should be on by default, and make it so.
TODO: We need to merge core patches so all the downloads we want are available.
TODO: We need to figure out if we want .swf, and if so what to do about the coreside (as it was removed from core in the past)
TODO: In presentations with videos, there seems to be something calling back to the server you downloaded from in SVG exports... this likely needs to be stripped.
Summary
TODO
Checklist
make prettier-writeand formatted the code.make checkmake runand manually verified that everything looks okay