Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify how environment variables and config files are used #100

Open
sandertan opened this issue Nov 25, 2022 · 0 comments
Open

Simplify how environment variables and config files are used #100

sandertan opened this issue Nov 25, 2022 · 0 comments

Comments

@sandertan
Copy link
Contributor

It would also be nice to simplify how the environment variables and config files for layers lower than the docker-compose are used. Currently they are passed on both using envs/env-file and environment: in the compose. There's also some discrepancy in how different compose files do this. We could move the environment variables from envs/env to .env-example and load them in the container with something like:

environment:
  - MEDCAT_CONFIG_FILE=${MEDCAT_CONFIG_FILE}

Related to this:
Can we clarify (and possibly simplify) how the config for MedCAT is used (currently configs/base.txt)? The recent versions of MedCAT contain a config within the CDB file, is this then the default configuration for a MCT project? What happens when the CDB config differs from the config at instance level? It would be nice to document the precedence. Also, we can document which parameters are relevant for which stage in MedCAT, like:

Parameter Creating CDB/Vocab NER+L MCT
CDBMaker.multi_separator x - -
General.make_pretty_labels - x -
General.spell_check_deep x x x
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant