Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split out non-Python assets in Publish Release workflow #6440

Merged

Conversation

Jackenmen
Copy link
Member

Description of the changes

The last release wasn't fully released through automation as usual since the recent changes to the workflow had a few issues.

Two of them have been solved while releasing:

But one remained - the dist/ directory containing files that aren't Python package distribution files caused the upload to PyPI to fail while collecting files to upload. This PR aims to fix that by splitting out application.yml (the only non-distribution artifact) into a different directory.

Have the changes in this PR been tested?

No

@Jackenmen Jackenmen added the Release Blocker This needs handling prior to the next non-hotfix release. label Aug 27, 2024
@Jackenmen Jackenmen added this to the 3.5.14 milestone Aug 27, 2024
@Jackenmen Jackenmen requested a review from Kowlin as a code owner August 27, 2024 00:19
@github-actions github-actions bot added the Category: CI This is related to repository's CI configuration. label Aug 27, 2024
@Jackenmen Jackenmen merged commit 907a3f7 into Cog-Creators:V3/develop Aug 28, 2024
18 checks passed
@red-githubbot red-githubbot bot added the Changelog Entry: Pending Changelog entry for this PR hasn't been added by repo maintainers yet. label Aug 28, 2024
@Jackenmen Jackenmen deleted the split_out_non_python_assets branch August 28, 2024 13:47
BenCos17 added a commit to JARVIS-discordbot/Red-DiscordBot-jarvis that referenced this pull request Aug 28, 2024
* [Trivia] Correct Stephen to Steven (Cog-Creators#6434)

Co-authored-by: Artemis6969 <[email protected]>

* Generate default LL server config and attach it to GH release (Cog-Creators#6430)

* [Audio] Update Lavalink.jar and yt source build numbers (Cog-Creators#6435)

Co-authored-by: Jakub Kuczys <[email protected]>

* [Audio] Fix trying to send notify message with no channel object (Cog-Creators#6429)

* Bump dependencies (Cog-Creators#6436)

* Red 3.5.13 - Changelog (Cog-Creators#6437)

* Automated Crowdin downstream (Cog-Creators#6439)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Version bump to 3.5.13 (Cog-Creators#6438)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Fix publish release workflow

* Add missing perm to Publish Release workflow

* Change Red 3.5.13 release date

* Version bump to 3.5.14.dev1

* [Trivia] Correct typos in World Cup trivia list for Golden Glove questions (Cog-Creators#6441)

* Split out non-Python assets in Publish Release workflow (Cog-Creators#6440)

---------

Co-authored-by: Guyonsteroids <[email protected]>
Co-authored-by: Artemis6969 <[email protected]>
Co-authored-by: Jakub Kuczys <[email protected]>
Co-authored-by: aikaterna <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Mellow <[email protected]>
BenCos17 added a commit to JARVIS-discordbot/Red-DiscordBot-jarvis that referenced this pull request Aug 30, 2024
* [Trivia] Correct Stephen to Steven (Cog-Creators#6434)

Co-authored-by: Artemis6969 <[email protected]>

* Generate default LL server config and attach it to GH release (Cog-Creators#6430)

* [Audio] Update Lavalink.jar and yt source build numbers (Cog-Creators#6435)

Co-authored-by: Jakub Kuczys <[email protected]>

* [Audio] Fix trying to send notify message with no channel object (Cog-Creators#6429)

* Bump dependencies (Cog-Creators#6436)

* Red 3.5.13 - Changelog (Cog-Creators#6437)

* Automated Crowdin downstream (Cog-Creators#6439)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Version bump to 3.5.13 (Cog-Creators#6438)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Fix publish release workflow

* Add missing perm to Publish Release workflow

* Change Red 3.5.13 release date

* Version bump to 3.5.14.dev1

* [Trivia] Correct typos in World Cup trivia list for Golden Glove questions (Cog-Creators#6441)

* Split out non-Python assets in Publish Release workflow (Cog-Creators#6440)

---------

Co-authored-by: Guyonsteroids <[email protected]>
Co-authored-by: Artemis6969 <[email protected]>
Co-authored-by: Jakub Kuczys <[email protected]>
Co-authored-by: aikaterna <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Mellow <[email protected]>
BenCos17 added a commit to JARVIS-discordbot/Red-DiscordBot-jarvis that referenced this pull request Sep 1, 2024
* [Trivia] Correct Stephen to Steven (Cog-Creators#6434)

Co-authored-by: Artemis6969 <[email protected]>

* Generate default LL server config and attach it to GH release (Cog-Creators#6430)

* [Audio] Update Lavalink.jar and yt source build numbers (Cog-Creators#6435)

Co-authored-by: Jakub Kuczys <[email protected]>

* [Audio] Fix trying to send notify message with no channel object (Cog-Creators#6429)

* Bump dependencies (Cog-Creators#6436)

* Red 3.5.13 - Changelog (Cog-Creators#6437)

* Automated Crowdin downstream (Cog-Creators#6439)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Version bump to 3.5.13 (Cog-Creators#6438)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Fix publish release workflow

* Add missing perm to Publish Release workflow

* Change Red 3.5.13 release date

* Version bump to 3.5.14.dev1

* [Trivia] Correct typos in World Cup trivia list for Golden Glove questions (Cog-Creators#6441)

* Split out non-Python assets in Publish Release workflow (Cog-Creators#6440)

* Add `header`, `hyperlink` and `subtext` utilities (Cog-Creators#6102) (#19)

Co-authored-by: Kreusada <[email protected]>
Co-authored-by: Kowlin <[email protected]>

---------

Co-authored-by: Guyonsteroids <[email protected]>
Co-authored-by: Artemis6969 <[email protected]>
Co-authored-by: Jakub Kuczys <[email protected]>
Co-authored-by: aikaterna <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Mellow <[email protected]>
Co-authored-by: Kreusada <[email protected]>
Co-authored-by: Kowlin <[email protected]>
Dav-Git pushed a commit to Dav-Git/Red-DiscordBot that referenced this pull request Sep 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: CI This is related to repository's CI configuration. Changelog Entry: Pending Changelog entry for this PR hasn't been added by repo maintainers yet. Release Blocker This needs handling prior to the next non-hotfix release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants