Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the changes
To support listing descriptions in
[p]trivia list
, there's a need for further optimizations in the list loading process.Optimizations made:
yaml.safe_load()
calls to use ofyaml.CSafeLoader
(C implementation of the parser) when possibleThe latter change is supposed to help us support retrieval of the actually needed fields without having to validate schema of the whole file, for example:
@Kreusada here's an example of how we can optimally get trivia descriptions for
[p]trivia list
output (10 per page in this example + cache for previously generated pages) when you work on it:Have the changes in this PR been tested?
Yes