-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correction of FrameUtility #46
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and update test_convert
…when the time 0 and when the time above the end of the video
…ion/normalization, moved back conversion methods inside class Convert, renamed Time class to TimeType, increased version, added ffms2 to dependencies, started to review tests and documentation
There is no point testing this feature. It will work if ms_to_frames and frames_to_ms works.
Superseded by #48 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finally, this should be the last version of FrameUtility.
For reference, here is the previous version: #37
Why it is needed?
The previous FrameUtility would not work with VFR video, now yes.
Finally, the previous FrameUtility was more a hack than anything else. Now it relies on the same algorithm as Aegisub.
What has been done?
How to get the timestamps from an video?
I did some test with multiple library.
I choose to use decord, because it was the second fastest and it is easy to install compared to some of them like pyffms2.
ffprobe is the best, but it need the user to have installed FFmpeg.
Important to note, decord seems to automatically normalize the timestamps.
Here is the script I used to compare all the librairies: Get timestamps.zip
Here is how much times it took to get the timestamps for an mkv of 24 minutes: