Add more description to Command and Parser classes #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looking good, I wish i knew more about how the comments in JS work for this kinda stuff, but i mainly am a go person |
|
Happy to merge this but there are a few conflicts now with another pull request, do you mind taking a look? |
|
All the conflicts resolved :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added more information inside the code about these new classes so its easier also following the guidelines so for example VS Code will show a tooltip with the information when hovering a method. #42
I have also splitted the commands in its own file so they are better located.
As further new PRs, I would add a tutorial on how to add types and new commands in the readme.