Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vis kun relevante afdelinger i dropdown på deltager admin side #954

Merged
merged 3 commits into from
Aug 20, 2023
Merged

Vis kun relevante afdelinger i dropdown på deltager admin side #954

merged 3 commits into from
Aug 20, 2023

Conversation

rasmusselsmark
Copy link
Contributor

Tidligere viste Afdelinger dropdown på https://members.codingpirates.dk/admin/members/activityparticipant/ alle afdelinger:
image

Med denne rettelse vises kun relevante afdelinger. Dette er samme kode som brugt i f.eks. https://github.com/CodingPirates/forenings_medlemmer/blob/master/members/admin/waitinglist_admin.py

@rasmusselsmark rasmusselsmark mentioned this pull request Aug 20, 2023
Closed
@what-the-diff
Copy link

what-the-diff bot commented Aug 20, 2023 •
edited
Loading

PR Summary

  • Simplified Department Retrieval in ActivityParticipantDepartmentFilter
    The updated code in ActivityParticipantDepartmentFilter now uses an existing method, AdminUserInformation.get_departments_admin, to access department data. This change replaces the former method which utilized a more complex, custom queryset. The benefits of this change include improved code maintainability and potential performance enhancement by reusing already optimized processes.

@rasmusselsmark rasmusselsmark linked an issue Aug 20, 2023 that may be closed by this pull request
[BUG]Admin > Deltagere: Afdelings filter viser alle afdelinger #951
Closed
@rasmusselsmark rasmusselsmark changed the title Vis kun relevante afdelinger på deltager admin side Vis kun relevante afdelinger i dropdown på deltager admin side Aug 20, 2023
mhewel
mhewel approved these changes Aug 20, 2023
View reviewed changes
Copy link
Contributor

@mhewel mhewel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Koden ser fornuftig ud

@mhewel mhewel merged commit 932c0bf into master Aug 20, 2023
2 checks passed
@rasmusselsmark rasmusselsmark deleted the 951-participants-only-show-own-departments branch August 31, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhewel mhewel mhewel approved these changes

@lakridserne lakridserne Awaiting requested review from lakridserne lakridserne is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]Admin > Deltagere: Afdelings filter viser alle afdelinger
2 participants
@rasmusselsmark @mhewel