Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rettede filtre for Grupper, Forening og Afdelinger #941

Conversation

mhewel
Copy link
Contributor

@mhewel mhewel commented Jul 12, 2023

Rettede logik for forenings og afdelings filtrene.
Tilføjede "ingen" til alle 3 filtre og "mindst en" for forenings- og afdelings filtrene.

Tilføjede "ingen" til alle 3 filtre og "mindst en" for forenings- og afdelings filtrene
Copy link
Contributor

@rasmusselsmark rasmusselsmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Primært til brug for sekretariatet, så de nemmere kan finde admins uden afdelinger, for en bestemt afdeling osv

@what-the-diff
Copy link

what-the-diff bot commented Aug 20, 2023

PR Summary

  • Improvements to User Admin Filters
    The filters which allow admin users to segment users based on their group, union, and department affiliations have been expanded. New choices have been added to each filter, offering more granularity when seeking specific user records. In particular, options have been added to allow for filtering on users with 'no group', 'no union' or 'no department', as well as users belonging to 'at least one union' or 'at least one department'.

  • Parameter Name Adjustment
    In an administrative improvement, the parameter name has been switched from union_id to department_id in the queryset method of the AdminUserDepartmentListFilter class. This change brings the nomenclature more in line with the object it refers to, increasing understandability of the codebase.

  • Enhancements to Queryset Handling
    Updates have been made to the queryset methods in AdminUserUnionListFilter and AdminUserDepartmentListFilter classes. These modifications serve to better handle the "any" option in the filters, providing more accurate results when this selection is made.

@rasmusselsmark rasmusselsmark merged commit 7aa4815 into master Aug 20, 2023
2 checks passed
@rasmusselsmark rasmusselsmark deleted the 937-bug-admin-brugere-filtre-for-foreninger-og-afdelinger-virker-ikke-ordentligt branch August 20, 2023 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]Admin > Brugere: Filtre for Foreninger og Afdelinger virker ikke ordentligt
2 participants