Features/finanskonto for foreninger #1126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
members/admin/union_admin.py
Outdated
Comment on lines
128
to
129
| print(f"info:{info_fields}") | ||
|
|
There was a problem hiding this comment.
Skal denne print() kommando være der?
Suggested change
| print(f"info:{info_fields}") |
members/admin/union_admin.py
Outdated
| # 20241113: https://stackoverflow.com/questions/16102222/djangoremove-superuser-checkbox-from-django-admin-panel-when-login-staff-users | ||
|
|
||
| if not obj: | ||
| print("not obj") |
There was a problem hiding this comment.
Ser ud til at være en debug-ting?
Suggested change
| print("not obj") |
members/admin/union_admin.py
Outdated
| ) | ||
|
|
||
| if not request.user.has_perm("members.showledgeraccount"): | ||
| print("no perm") |
There was a problem hiding this comment.
Tænker denne også kan fjernes?
Suggested change
| print("no perm") |
| "ordering": ["name"], | ||
| "permissions": ( | ||
| ("view_all_unions", "Can view all Foreninger"), | ||
| ("showledgeraccount", "Show General Ledger Account"), |
There was a problem hiding this comment.
Bare for at være konsistent med andre permission definitions?
Suggested change
| ("showledgeraccount", "Show General Ledger Account"), | |
| ("show_ledger_account", "Show General Ledger Account"), |
There was a problem hiding this comment.
Der findes en senere migration hvor det ændres til det.
| field=models.CharField( | ||
| blank=True, | ||
| help_text="Kontonummer i formatet 1234", | ||
| max_length=4, |
There was a problem hiding this comment.
Har vi bekræftet med bogholder at vi max vil have 4 tegn i kontonumre?
There was a problem hiding this comment.
Det var kravet som Anders har angivet
lakridserne
approved these changes
Nov 13, 2024
| "ordering": ["name"], | ||
| "permissions": ( | ||
| ("view_all_unions", "Can view all Foreninger"), | ||
| ("showledgeraccount", "Show General Ledger Account"), |
There was a problem hiding this comment.
Der findes en senere migration hvor det ændres til det.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ny rettighed : "Show General Ledger Account" for at vise/redigere finans konto for foreninger