Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opdater AdminActions.invite_many_to_activity_action: Vis kun åbne afdelinger #1119

Conversation

mhewel
Copy link
Contributor

@mhewel mhewel commented Oct 27, 2024

Dette er ifm siden hvor man skal bekræftige afdeling + aktivitet samt evt skrive mere info til invitation

Copy link

what-the-diff bot commented Oct 27, 2024

PR Summary

  • Improvement in Activity Invitation Process
    Updated the system action responsible for inviting multiple participants to activity for more effective filtering. Now, it will ignore 'closed' departments in both superuser and normal user situations. This prevents sending unnecessary invitations to inactive sections.

  • Testing Enhancements for Admin Actions
    Updated the testing framework for admin tasks to match the current invite activity process. More specifically, we have included a scenario where a department is open (or not closed), ensuring the tests are aligned with the latest administrative task processes.

…n-aktivitet-liste-af-afdelinger-indeholder-også-lukkede-afdelinger
Copy link
Contributor

@rasmusselsmark rasmusselsmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fald en afdeling er sat til at lukke om ét år, vil det ikke være være muligt at invitere efter denne rettelse, men vi formoder ikke dette er et problem i praksis.

Testet og valideret lokalt at man kan invitere

@rasmusselsmark rasmusselsmark merged commit a8145a0 into master Oct 27, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]Admin : Invitation af personer til en aktivitet: Liste af afdelinger indeholder også lukkede afdelinger
2 participants