LDAP3: Allow the user to set the search filter. #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
have tested this locally - works well :) |
|
I agree that the changes work, though I'm a little concerned that we can add these changes without needing to reflect any of it in documentation or tests. It seems that we don't have an example config for the ldap3 source, though a user would be given a hint that the fields exist because apidoc pulls out the value of optional_fields. I'm happy to approve this as-is, if we create an issue about the test coverage and documentation gap for when we have the development bandwidth to cover them. |
This should allow us to only sync a subset of users. Closes: #98
thinkl33t
force-pushed
the
bobclough/ldap-add-search-filters
branch
from
2a6056a
to
1b49689
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should allow us to only sync a subset of users.
Closes: #98