Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code refactoring #3

Merged
merged 5 commits into from
Dec 3, 2024
Merged

Code refactoring #3

merged 5 commits into from
Dec 3, 2024

Conversation

leoppark94
Copy link
Collaborator

Updated the code to add various features.

  • Code cleanup
  • Support for query testing
  • Support for generating new data formats

This PR is created assuming that the existing PR will be merged.

@leoppark94 leoppark94 force-pushed the leopark/refactoring branch 3 times, most recently from 94605e2 to 5bffb3d Compare November 29, 2024 13:05
Copy link
Collaborator

@TBSliver TBSliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some minor changes

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@leoppark94 leoppark94 force-pushed the leopark/refactoring branch 3 times, most recently from d509894 to 24cd95d Compare November 29, 2024 14:29
Copy link
Collaborator

@TBSliver TBSliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few more changes, looking good though!

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@leoppark94 leoppark94 force-pushed the leopark/refactoring branch 5 times, most recently from 4ae7d7c to 651241f Compare November 29, 2024 15:42
- Modularize and polish existing code
- Implement Faker library with seed configuration
- Add query testing functionality
- Add Dockerfile
- Include requirements.txt for dependency management
@leoppark94 leoppark94 force-pushed the leopark/refactoring branch 3 times, most recently from e2d72e8 to e915c68 Compare November 29, 2024 15:56
Copy link
Collaborator

@TBSliver TBSliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@leoppark94 leoppark94 merged commit 1bc256e into codethink Dec 3, 2024
1 check passed
@TBSliver TBSliver deleted the leopark/refactoring branch December 4, 2024 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants