Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add release workflow #1

Merged
merged 3 commits into from
Aug 13, 2024
Merged

Add release workflow #1

merged 3 commits into from
Aug 13, 2024

Conversation

sdclarke
Copy link
Collaborator

@sdclarke sdclarke commented Aug 8, 2024

Add a workflow which runs when new tags are created to push the role to Ansible Galaxy

@sdclarke sdclarke marked this pull request as draft August 9, 2024 13:25
@sdclarke sdclarke marked this pull request as ready for review August 12, 2024 14:51
@sdclarke
Add release workflow
cc8f51a 
This workflow will import the role into Ansible Galaxy when a new tag is
pushed to the repository
@sdclarke sdclarke force-pushed the scott/add-release-workflow branch from 76a6bf6 to cc8f51a Compare August 12, 2024 15:19
@sdclarke sdclarke force-pushed the scott/add-release-workflow branch from 9647787 to fac6bd4 Compare August 13, 2024 08:55
jjardon
jjardon requested changes Aug 13, 2024
View reviewed changes
Copy link
Contributor

@jjardon jjardon left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Split the "Add linting to CI and fix linting failures" commit in 2 please: one to fix the problems, other to add the linting job

@sdclarke
Fix linting issues
d85adfe 
The issues addressed are:
- lines which were too long
- truthy values not being specified with `true`
- adding the namespace to the metadata for the role
@sdclarke sdclarke force-pushed the scott/add-release-workflow branch from fac6bd4 to 6224ee9 Compare August 13, 2024 09:56
@sdclarke sdclarke force-pushed the scott/add-release-workflow branch from 6224ee9 to 60c1caa Compare August 13, 2024 10:06
@sdclarke
Copy link
Collaborator Author

Split the "Add linting to CI and fix linting failures" commit in 2 please: one to fix the problems, other to add the linting job

Done

@sdclarke sdclarke merged commit 542d7b1 into main Aug 13, 2024
1 check passed
@sdclarke sdclarke deleted the scott/add-release-workflow branch August 16, 2024 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjardon jjardon jjardon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sdclarke @jjardon