style: apply new php cs fixer rules

CodelyTV · Sep 27, 2023 · 751c0bc · 751c0bc
1 parent 15c2952
commit 751c0bc
Show file tree

Hide file tree

Showing 135 changed files with 238 additions and 433 deletions.
diff --git a/apps/backoffice/backend/config/bundles.php b/apps/backoffice/backend/config/bundles.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 return [
     Symfony\Bundle\FrameworkBundle\FrameworkBundle::class => ['all' => true],
     FriendsOfBehat\SymfonyExtension\Bundle\FriendsOfBehatSymfonyExtensionBundle::class => ['test' => true],

diff --git a/apps/backoffice/backend/public/index.php b/apps/backoffice/backend/public/index.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 use CodelyTv\Apps\Backoffice\Backend\BackofficeBackendKernel;
 use Symfony\Component\ErrorHandler\Debug;
 use Symfony\Component\HttpFoundation\Request;

diff --git a/apps/backoffice/backend/src/Controller/Courses/CoursesGetController.php b/apps/backoffice/backend/src/Controller/Courses/CoursesGetController.php
@@ -15,9 +15,7 @@
 
 final readonly class CoursesGetController
 {
-    public function __construct(private QueryBus $queryBus)
-    {
-    }
+    public function __construct(private QueryBus $queryBus) {}
 
     public function __invoke(Request $request): JsonResponse
     {
@@ -30,10 +28,10 @@ public function __invoke(Request $request): JsonResponse
         $response = $this->queryBus->ask(
             new SearchBackofficeCoursesByCriteriaQuery(
                 (array) $request->query->get('filters'),
-                null === $orderBy ? null : (string) $orderBy,
-                null === $order ? null : (string) $order,
-                null === $limit ? null : (int) $limit,
-                null === $offset ? null : (int) $offset
+                $orderBy === null ? null : (string) $orderBy,
+                $order === null ? null : (string) $order,
+                $limit === null ? null : (int) $limit,
+                $offset === null ? null : (int) $offset
             )
         );
 

diff --git a/apps/backoffice/backend/src/Controller/Metrics/MetricsController.php b/apps/backoffice/backend/src/Controller/Metrics/MetricsController.php
@@ -11,9 +11,7 @@
 
 final readonly class MetricsController
 {
-    public function __construct(private PrometheusMonitor $monitor)
-    {
-    }
+    public function __construct(private PrometheusMonitor $monitor) {}
 
     public function __invoke(Request $request): Response
     {

diff --git a/apps/backoffice/frontend/config/bundles.php b/apps/backoffice/frontend/config/bundles.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 return [
     Symfony\Bundle\FrameworkBundle\FrameworkBundle::class => ['all' => true],
     FriendsOfBehat\SymfonyExtension\Bundle\FriendsOfBehatSymfonyExtensionBundle::class => ['test' => true],

diff --git a/apps/backoffice/frontend/public/index.php b/apps/backoffice/frontend/public/index.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 use CodelyTv\Apps\Backoffice\Frontend\BackofficeFrontendKernel;
 use Symfony\Component\ErrorHandler\Debug;
 use Symfony\Component\HttpFoundation\Request;

diff --git a/apps/backoffice/frontend/src/Controller/Metrics/MetricsController.php b/apps/backoffice/frontend/src/Controller/Metrics/MetricsController.php
@@ -11,9 +11,7 @@
 
 final readonly class MetricsController
 {
-    public function __construct(private PrometheusMonitor $monitor)
-    {
-    }
+    public function __construct(private PrometheusMonitor $monitor) {}
 
     public function __invoke(Request $request): Response
     {

diff --git a/apps/bootstrap.php b/apps/bootstrap.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 use Symfony\Component\Dotenv\Dotenv;
 
 $rootPath = dirname(__DIR__);
@@ -23,6 +25,6 @@
 
 $_SERVER += $_ENV;
 $_SERVER['APP_ENV'] = $_ENV['APP_ENV'] = ($_SERVER['APP_ENV'] ?? $_ENV['APP_ENV'] ?? null) ?: 'dev';
-$_SERVER['APP_DEBUG'] ??= $_ENV['APP_DEBUG'] ?? 'prod' !== $_SERVER['APP_ENV'];
+$_SERVER['APP_DEBUG'] ??= $_ENV['APP_DEBUG'] ?? $_SERVER['APP_ENV'] !== 'prod';
 $_SERVER['APP_DEBUG'] = $_ENV['APP_DEBUG'] =
     (int) $_SERVER['APP_DEBUG'] || filter_var($_SERVER['APP_DEBUG'], FILTER_VALIDATE_BOOLEAN) ? '1' : '0';
diff --git a/apps/mooc/backend/config/bundles.php b/apps/mooc/backend/config/bundles.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 return [
     Symfony\Bundle\FrameworkBundle\FrameworkBundle::class => ['all' => true],
     FriendsOfBehat\SymfonyExtension\Bundle\FriendsOfBehatSymfonyExtensionBundle::class => ['test' => true],

diff --git a/apps/mooc/backend/public/index.php b/apps/mooc/backend/public/index.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 use CodelyTv\Apps\Mooc\Backend\MoocBackendKernel;
 use Symfony\Component\ErrorHandler\Debug;
 use Symfony\Component\HttpFoundation\Request;

diff --git a/...kend/src/Command/DomainEvents/RabbitMq/GenerateSupervisorRabbitMqConsumerFilesCommand.php b/...kend/src/Command/DomainEvents/RabbitMq/GenerateSupervisorRabbitMqConsumerFilesCommand.php
@@ -49,13 +49,7 @@ private function configCreator(string $path): callable
             $subscriberName = RabbitMqQueueNameFormatter::shortFormat($subscriber);
 
             $fileContent = str_replace(
-                [
-                    '{subscriber_name}',
-                    '{queue_name}',
-                    '{path}',
-                    '{processes}',
-                    '{events_to_process}',
-                ],
+                ['{subscriber_name}', '{queue_name}', '{path}', '{processes}', '{events_to_process}', ],
                 [
                     $subscriberName,
                     $queueName,

diff --git a/apps/mooc/backend/src/Controller/HealthCheck/HealthCheckGetController.php b/apps/mooc/backend/src/Controller/HealthCheck/HealthCheckGetController.php
@@ -10,9 +10,7 @@
 
 final readonly class HealthCheckGetController
 {
-    public function __construct(private RandomNumberGenerator $generator)
-    {
-    }
+    public function __construct(private RandomNumberGenerator $generator) {}
 
     public function __invoke(Request $request): JsonResponse
     {

diff --git a/apps/mooc/backend/src/Controller/Metrics/MetricsController.php b/apps/mooc/backend/src/Controller/Metrics/MetricsController.php
@@ -11,9 +11,7 @@
 
 final readonly class MetricsController
 {
-    public function __construct(private PrometheusMonitor $monitor)
-    {
-    }
+    public function __construct(private PrometheusMonitor $monitor) {}
 
     public function __invoke(Request $request): Response
     {

diff --git a/ecs.php b/ecs.php
@@ -45,12 +45,11 @@
 use PhpCsFixer\Fixer\PhpUnit\PhpUnitMethodCasingFixer;
 use PhpCsFixer\Fixer\Strict\DeclareStrictTypesFixer;
 use PhpCsFixer\Fixer\Strict\StrictComparisonFixer;
-use PhpCsFixer\Fixer\Strict\StrictParamFixer;
 use PhpCsFixer\Fixer\StringNotation\SingleQuoteFixer;
-use Symplify\CodingStandard\Fixer\ArrayNotation\ArrayListItemNewlineFixer;
-use Symplify\CodingStandard\Fixer\ArrayNotation\ArrayOpenerAndCloserNewlineFixer;
+use PhpCsFixer\Fixer\Whitespace\StatementIndentationFixer;
+use PhpCsFixer\Fixer\Whitespace\TypeDeclarationSpacesFixer;
+use PhpCsFixer\Fixer\Whitespace\TypesSpacesFixer;
 use Symplify\CodingStandard\Fixer\LineLength\LineLengthFixer;
-use Symplify\CodingStandard\Fixer\Spacing\MethodChainingNewlineFixer;
 use Symplify\CodingStandard\Fixer\Strict\BlankLineAfterStrictTypesFixer;
 use Symplify\EasyCodingStandard\Config\ECSConfig;
 use Symplify\EasyCodingStandard\ValueObject\Set\SetList;
@@ -71,24 +70,21 @@
         GlobalNamespaceImportFixer::class,
         NoLeadingImportSlashFixer::class,
         // Arrays
-        ArrayListItemNewlineFixer::class,
-        ArrayOpenerAndCloserNewlineFixer::class,
         TrimArraySpacesFixer::class,
         // Blank lines
         BlankLineAfterStrictTypesFixer::class,
         NoBlankLinesAfterClassOpeningFixer::class,
         // Spacing
-        MethodChainingNewlineFixer::class,
         SingleLineEmptyBodyFixer::class,
         CastSpacesFixer::class,
+        TypeDeclarationSpacesFixer::class,
+        TypesSpacesFixer::class,
         // Casing
         ClassReferenceNameCasingFixer::class,
         LowercaseStaticReferenceFixer::class,
         MagicMethodCasingFixer::class,
         NativeFunctionCasingFixer::class,
         NativeFunctionTypeDeclarationCasingFixer::class,
-        // Order
-        OrderedTypesFixer::class,
         // Architecture
         FinalClassFixer::class,
         FinalPublicMethodForAbstractClassFixer::class,
@@ -121,10 +117,12 @@
         DeclareStrictTypesFixer::class,
         StrictComparisonFixer::class,
         SingleQuoteFixer::class,
+        StatementIndentationFixer::class,
     ]);
 
     $ecsConfig->ruleWithConfiguration(ArraySyntaxFixer::class, ['syntax' => 'short']);
     $ecsConfig->ruleWithConfiguration(LineLengthFixer::class, [LineLengthFixer::LINE_LENGTH => 120]);
     $ecsConfig->ruleWithConfiguration(YodaStyleFixer::class, ['equal' => false, 'identical' => false, 'less_and_greater' => false]);
     $ecsConfig->ruleWithConfiguration(PhpUnitMethodCasingFixer::class, ['case' => PhpUnitMethodCasingFixer::SNAKE_CASE]);
+    $ecsConfig->ruleWithConfiguration(OrderedTypesFixer::class, ['null_adjustment' => 'always_last']);
 };
diff --git a/src/Analytics/DomainEvents/Application/Store/DomainEventStorer.php b/src/Analytics/DomainEvents/Application/Store/DomainEventStorer.php
@@ -13,9 +13,7 @@
 
 final readonly class DomainEventStorer
 {
-    public function __construct(private DomainEventsRepository $repository)
-    {
-    }
+    public function __construct(private DomainEventsRepository $repository) {}
 
     public function store(
         AnalyticsDomainEventId $id,

diff --git a/src/Analytics/DomainEvents/Application/Store/StoreDomainEventOnOccurred.php b/src/Analytics/DomainEvents/Application/Store/StoreDomainEventOnOccurred.php
@@ -13,9 +13,7 @@
 
 final readonly class StoreDomainEventOnOccurred implements DomainEventSubscriber
 {
-    public function __construct(private DomainEventStorer $storer)
-    {
-    }
+    public function __construct(private DomainEventStorer $storer) {}
 
     public static function subscribedTo(): array
     {

diff --git a/src/Analytics/DomainEvents/Domain/AnalyticsDomainEvent.php b/src/Analytics/DomainEvents/Domain/AnalyticsDomainEvent.php
@@ -11,6 +11,5 @@ public function __construct(
         private AnalyticsDomainEventAggregateId $aggregateId,
         private AnalyticsDomainEventName $name,
         private AnalyticsDomainEventBody $body
-    ) {
-    }
+    ) {}
 }
diff --git a/src/Analytics/DomainEvents/Domain/AnalyticsDomainEventAggregateId.php b/src/Analytics/DomainEvents/Domain/AnalyticsDomainEventAggregateId.php
@@ -6,6 +6,4 @@
 
 use CodelyTv\Shared\Domain\ValueObject\Uuid;
 
-final class AnalyticsDomainEventAggregateId extends Uuid
-{
-}
+final class AnalyticsDomainEventAggregateId extends Uuid {}
diff --git a/src/Analytics/DomainEvents/Domain/AnalyticsDomainEventBody.php b/src/Analytics/DomainEvents/Domain/AnalyticsDomainEventBody.php
@@ -6,9 +6,7 @@
 
 final readonly class AnalyticsDomainEventBody
 {
-    public function __construct(private array $value)
-    {
-    }
+    public function __construct(private array $value) {}
 
     public function value(): array
     {

diff --git a/src/Analytics/DomainEvents/Domain/AnalyticsDomainEventId.php b/src/Analytics/DomainEvents/Domain/AnalyticsDomainEventId.php
@@ -6,6 +6,4 @@
 
 use CodelyTv\Shared\Domain\ValueObject\Uuid;
 
-final class AnalyticsDomainEventId extends Uuid
-{
-}
+final class AnalyticsDomainEventId extends Uuid {}
diff --git a/src/Analytics/DomainEvents/Domain/AnalyticsDomainEventName.php b/src/Analytics/DomainEvents/Domain/AnalyticsDomainEventName.php
@@ -6,6 +6,4 @@
 
 use CodelyTv\Shared\Domain\ValueObject\StringValueObject;
 
-final class AnalyticsDomainEventName extends StringValueObject
-{
-}
+final class AnalyticsDomainEventName extends StringValueObject {}
diff --git a/src/Backoffice/Auth/Application/Authenticate/AuthenticateUserCommand.php b/src/Backoffice/Auth/Application/Authenticate/AuthenticateUserCommand.php
@@ -8,9 +8,7 @@
 
 final readonly class AuthenticateUserCommand implements Command
 {
-    public function __construct(private string $username, private string $password)
-    {
-    }
+    public function __construct(private string $username, private string $password) {}
 
     public function username(): string
     {

diff --git a/src/Backoffice/Auth/Application/Authenticate/AuthenticateUserCommandHandler.php b/src/Backoffice/Auth/Application/Authenticate/AuthenticateUserCommandHandler.php
@@ -10,9 +10,7 @@
 
 final readonly class AuthenticateUserCommandHandler implements CommandHandler
 {
-    public function __construct(private UserAuthenticator $authenticator)
-    {
-    }
+    public function __construct(private UserAuthenticator $authenticator) {}
 
     public function __invoke(AuthenticateUserCommand $command): void
     {

diff --git a/src/Backoffice/Auth/Application/Authenticate/UserAuthenticator.php b/src/Backoffice/Auth/Application/Authenticate/UserAuthenticator.php
@@ -13,9 +13,7 @@
 
 final readonly class UserAuthenticator
 {
-    public function __construct(private AuthRepository $repository)
-    {
-    }
+    public function __construct(private AuthRepository $repository) {}
 
     public function authenticate(AuthUsername $username, AuthPassword $password): void
     {
@@ -27,7 +25,7 @@ public function authenticate(AuthUsername $username, AuthPassword $password): vo
 
     private function ensureUserExist(?AuthUser $auth, AuthUsername $username): void
     {
-        if (null === $auth) {
+        if ($auth === null) {
             throw new InvalidAuthUsername($username);
         }
     }

diff --git a/src/Backoffice/Auth/Domain/AuthPassword.php b/src/Backoffice/Auth/Domain/AuthPassword.php
@@ -8,7 +8,7 @@
 
 final class AuthPassword extends StringValueObject
 {
-    public function isEquals(AuthPassword $other): bool
+    public function isEquals(self $other): bool
     {
         return $this->value() === $other->value();
     }

diff --git a/src/Backoffice/Auth/Domain/AuthUser.php b/src/Backoffice/Auth/Domain/AuthUser.php
@@ -6,9 +6,7 @@
 
 final readonly class AuthUser
 {
-    public function __construct(private AuthUsername $username, private AuthPassword $password)
-    {
-    }
+    public function __construct(private AuthUsername $username, private AuthPassword $password) {}
 
     public function passwordMatches(AuthPassword $password): bool
     {

diff --git a/src/Backoffice/Auth/Domain/AuthUsername.php b/src/Backoffice/Auth/Domain/AuthUsername.php
@@ -6,6 +6,4 @@
 
 use CodelyTv\Shared\Domain\ValueObject\StringValueObject;
 
-final class AuthUsername extends StringValueObject
-{
-}
+final class AuthUsername extends StringValueObject {}
diff --git a/src/Backoffice/Auth/Infrastructure/Persistence/InMemoryAuthRepository.php b/src/Backoffice/Auth/Infrastructure/Persistence/InMemoryAuthRepository.php
@@ -22,6 +22,6 @@ public function search(AuthUsername $username): ?AuthUser
     {
         $password = get($username->value(), self::USERS);
 
-        return null !== $password ? new AuthUser($username, new AuthPassword($password)) : null;
+        return $password !== null ? new AuthUser($username, new AuthPassword($password)) : null;
     }
 }
diff --git a/src/Backoffice/Courses/Application/BackofficeCourseResponse.php b/src/Backoffice/Courses/Application/BackofficeCourseResponse.php
@@ -6,9 +6,7 @@
 
 final readonly class BackofficeCourseResponse
 {
-    public function __construct(private string $id, private string $name, private string $duration)
-    {
-    }
+    public function __construct(private string $id, private string $name, private string $duration) {}
 
     public function id(): string
     {

diff --git a/src/Backoffice/Courses/Application/Create/BackofficeCourseCreator.php b/src/Backoffice/Courses/Application/Create/BackofficeCourseCreator.php
@@ -9,9 +9,7 @@
 
 final readonly class BackofficeCourseCreator
 {
-    public function __construct(private BackofficeCourseRepository $repository)
-    {
-    }
+    public function __construct(private BackofficeCourseRepository $repository) {}
 
     public function create(string $id, string $name, string $duration): void
     {

diff --git a/src/Backoffice/Courses/Application/Create/CreateBackofficeCourseOnCourseCreated.php b/src/Backoffice/Courses/Application/Create/CreateBackofficeCourseOnCourseCreated.php
@@ -9,9 +9,7 @@
 
 final readonly class CreateBackofficeCourseOnCourseCreated implements DomainEventSubscriber
 {
-    public function __construct(private BackofficeCourseCreator $creator)
-    {
-    }
+    public function __construct(private BackofficeCourseCreator $creator) {}
 
     public static function subscribedTo(): array
     {

diff --git a/src/Backoffice/Courses/Application/SearchAll/AllBackofficeCoursesSearcher.php b/src/Backoffice/Courses/Application/SearchAll/AllBackofficeCoursesSearcher.php
@@ -13,9 +13,7 @@
 
 final readonly class AllBackofficeCoursesSearcher
 {
-    public function __construct(private BackofficeCourseRepository $repository)
-    {
-    }
+    public function __construct(private BackofficeCourseRepository $repository) {}
 
     public function searchAll(): BackofficeCoursesResponse
     {

diff --git a/src/Backoffice/Courses/Application/SearchAll/SearchAllBackofficeCoursesQuery.php b/src/Backoffice/Courses/Application/SearchAll/SearchAllBackofficeCoursesQuery.php
@@ -6,6 +6,4 @@
 
 use CodelyTv\Shared\Domain\Bus\Query\Query;
 
-final class SearchAllBackofficeCoursesQuery implements Query
-{
-}
+final class SearchAllBackofficeCoursesQuery implements Query {}