Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Breadcrumb NavXT breadcrumb rendering #4272

Merged
merged 1 commit into from
Jul 31, 2024

Conversation

piit79
Copy link
Contributor

@piit79 piit79 commented Jul 14, 2024

This fixes Breadcrumb NavXT breadcrumb rendering which was removed by in ee748ab (by mistake I assume).

I tested the change (in prod 😉) on my WordPress/WooCommerce installation.

Summary

This change re-adds the code that calls the bcn_display() Breadcrumb NavXT function to display the breadcrumbs.

Will affect visual aspect of the product

YES (I guess? It adds breadcrumbs that have been missing)

Screenshots

Test instructions

  • Install WordPress with Neve
  • Install Breadcrumb NavXT and enable breadcrumbs
  • Breadcrumbs will not be rendered
  • Update the Neve code with this PR
  • Breadcrumbs will now be rendered correctly

Check before Pull Request is ready:

Closes #4267.

@selul selul changed the base branch from master to development July 31, 2024 08:00
@selul
Copy link
Contributor

selul commented Jul 31, 2024

@piit79 Thank you for your contribution.

@selul selul merged commit 4bba50c into Codeinwp:development Jul 31, 2024
2 of 3 checks passed
@pirate-bot
Copy link
Collaborator

🎉 This PR is included in version 3.8.11 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Breadcrumb NavXT integration is broken
3 participants