Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: mega menu opening on tablet #4209

Merged
merged 1 commit into from
Mar 12, 2024
Merged

Conversation

preda-bogdan
Copy link
Contributor

Summary

Override calculated styles for the mega-menu as it uses a different display style for the dropdown.
The translateX changes were introduced here: #4165 previous properties like right and left are overridden by mega-menu styles the translateX were not as it was not expected there.

Will affect the visual aspect of the product

YES

Screenshots

Test instructions

  1. On a fresh instance with Neve and Neve PRO
  2. Enable the Mega Menu and use it for the Primary Menu.
  3. Check that on the front end for the emulated tablet (iPad), it opens and displays correctly.

Check before Pull Request is ready:

Closes: Codeinwp/neve-pro-addon#2769.

Override calculated styles for the mega-menu as it uses a different display style for the dropdown.

Closes: Codeinwp/neve-pro-addon#2769
@preda-bogdan preda-bogdan added the pr-checklist-skip Allow this Pull Request to skip checklist. label Feb 28, 2024
@pirate-bot pirate-bot added pr-checklist-complete The Pull Request checklist is complete. (automatic label) labels Feb 28, 2024
@pirate-bot
Copy link
Collaborator

Plugin build for 2260481 is ready 🛎️!

@irinelenache
Copy link
Contributor

@preda-bogdan Tested and the issue is fixed now 🚀

@preda-bogdan preda-bogdan merged commit 2e55cc0 into development Mar 12, 2024
18 checks passed
@preda-bogdan preda-bogdan deleted the fix/mega_menu_tablet branch March 12, 2024 10:47
@pirate-bot
Copy link
Collaborator

🎉 This PR is included in version 3.8.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-checklist-complete The Pull Request checklist is complete. (automatic label) pr-checklist-skip Allow this Pull Request to skip checklist. released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants