Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disable excerpt more filter when excerpt block is used #4205

Merged
merged 2 commits into from
Mar 12, 2024

Conversation

GrigoreMihai
Copy link
Contributor

@GrigoreMihai GrigoreMihai commented Feb 22, 2024

Summary

During the render_block_data filter we check if the rendered block is a core/post-excerpt block and we disable our excerpt addon for the first call after the render_block_data hook.

Will affect visual aspect of the product

NO

Screenshots

Duplicate read more is no longer present when the excert more block is used: https://vertis.d.pr/i/aqx1p7 and works as excepted in the rest of the cases: https://vertis.d.pr/i/uAYkUZ .

Test instructions

Check the instructions from the linked issue for replication. The read more should not be doubled anymore.

Check before Pull Request is ready:

Closes #4187.

@pirate-bot pirate-bot added the pr-checklist-incomplete The Pull Request checklist is incomplete. (automatic label) label Feb 22, 2024
@pirate-bot
Copy link
Collaborator

pirate-bot commented Feb 22, 2024

Plugin build for 07f0571 is ready 🛎️!

@GrigoreMihai GrigoreMihai added the pr-checklist-skip Allow this Pull Request to skip checklist. label Feb 22, 2024
@pirate-bot pirate-bot added pr-checklist-complete The Pull Request checklist is complete. (automatic label) and removed pr-checklist-incomplete The Pull Request checklist is incomplete. (automatic label) labels Feb 22, 2024
@irinelenache
Copy link
Contributor

@GrigoreMihai Tested and the issue is fixed now 🚀

@preda-bogdan preda-bogdan merged commit 21f55ab into development Mar 12, 2024
24 of 28 checks passed
@preda-bogdan preda-bogdan deleted the fix/4187 branch March 12, 2024 10:46
@pirate-bot
Copy link
Collaborator

🎉 This PR is included in version 3.8.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-checklist-complete The Pull Request checklist is complete. (automatic label) pr-checklist-skip Allow this Pull Request to skip checklist. released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants