Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for Black Friday 2024 #4197

Merged
merged 7 commits into from
Feb 22, 2024
Merged

Conversation

Soare-Robert-Daniel
Copy link
Contributor

@Soare-Robert-Daniel Soare-Robert-Daniel commented Jan 30, 2024

Summary

The Limited Offer class will now use the data provided by the SDK

Will affect visual aspect of the product

NO

Screenshots

Dashboard

image

Customizer

image

Test instructions

  • Should be testing using this version of SDK: https://github.com/Codeinwp/themeisle-sdk/pull/208
  • You should see the banner in Neve Options > Settings and Customizer when you set your date to match the black Friday campaign (Read in the PR above).
  • Outside the campaign, it should not be visible

Check before Pull Request is ready:

Close https://github.com/Codeinwp/themeisle/issues/1613

@Soare-Robert-Daniel Soare-Robert-Daniel added the pr-checklist-skip Allow this Pull Request to skip checklist. label Jan 30, 2024
@Soare-Robert-Daniel Soare-Robert-Daniel self-assigned this Jan 30, 2024
@Soare-Robert-Daniel Soare-Robert-Daniel marked this pull request as ready for review January 30, 2024 15:07
@pirate-bot
Copy link
Collaborator

pirate-bot commented Jan 30, 2024

Plugin build for 1803229 is ready 🛎️!

@pirate-bot pirate-bot added the pr-checklist-complete The Pull Request checklist is complete. (automatic label) label Jan 31, 2024
Copy link
Contributor

@preda-bogdan preda-bogdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a question, If Neve PRO is present do we still show the announcement, it looks like from the code. Shouldn't we only display the announcement only for FREE? Let me know if I am missing something.

inc/core/limited_offers.php Outdated Show resolved Hide resolved
@Soare-Robert-Daniel
Copy link
Contributor Author

@preda-bogdan, the Neve Pro checks are present:

Dashboard:

'deal' => ! defined( 'NEVE_PRO_VERSION' ) ? $offer->get_localized_data() : array(),

Customizer:

'deal' => ! defined( 'NEVE_PRO_VERSION' ) ? $offer->get_localized_data() : array(),

@preda-bogdan preda-bogdan merged commit 6826d27 into development Feb 22, 2024
15 checks passed
@preda-bogdan preda-bogdan deleted the feat/black-friday-2024 branch February 22, 2024 13:10
@pirate-bot
Copy link
Collaborator

🎉 This PR is included in version 3.8.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-checklist-complete The Pull Request checklist is complete. (automatic label) pr-checklist-skip Allow this Pull Request to skip checklist. released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants