Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support changes for the custom svg menu icon #4135

Merged
merged 15 commits into from
Jan 25, 2024

Conversation

cristian-ungureanu
Copy link
Contributor

@cristian-ungureanu cristian-ungureanu commented Nov 7, 2023

Summary

  • Added the support changes for the custom SVG icon for the menu icon

(Edited: @preda-bogdan ):

  • Extended the neve_kses_svg sanitization function
  • Registered a new control for Icon size to be used when using a Custom SVG Icon

Will affect the visual aspect of the product

NO

Test instructions

  1. On a fresh instance of Neve
  2. Check that the Menu Icon component works as before when Neve Pro is not active

Check before Pull Request is ready:

Closes Codeinwp/neve-pro-addon#2625.

@cristian-ungureanu cristian-ungureanu added the pr-checklist-skip Allow this Pull Request to skip checklist. label Nov 7, 2023
@pirate-bot pirate-bot added the pr-checklist-complete The Pull Request checklist is complete. (automatic label) label Nov 7, 2023
@cristian-ungureanu cristian-ungureanu changed the title Custom svg menu icon Support changes for the custom svg menu icon Nov 7, 2023
@pirate-bot
Copy link
Collaborator

pirate-bot commented Nov 7, 2023

Plugin build for 3ea9441 is ready 🛎️!

@preda-bogdan preda-bogdan merged commit 7ea56bf into new/next Jan 25, 2024
8 checks passed
@preda-bogdan preda-bogdan deleted the feat/custom-svg-menu-icon branch January 25, 2024 13:56
@pirate-bot
Copy link
Collaborator

🎉 This PR is included in version 3.8.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-checklist-complete The Pull Request checklist is complete. (automatic label) pr-checklist-skip Allow this Pull Request to skip checklist. released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants