Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: accessibility issue [#4099] #4104

Merged
merged 2 commits into from
Oct 5, 2023

Conversation

cristian-ungureanu
Copy link
Contributor

@cristian-ungureanu cristian-ungureanu commented Sep 27, 2023

Summary

  • Added the description inside the aria-label attribute.

Will affect the visual aspect of the product

NO

Test instructions

Check before Pull Request is ready:

Closes #4099.

@cristian-ungureanu cristian-ungureanu added the pr-checklist-skip Allow this Pull Request to skip checklist. label Sep 27, 2023
@pirate-bot pirate-bot added the pr-checklist-complete The Pull Request checklist is complete. (automatic label) label Sep 27, 2023
@pirate-bot
Copy link
Collaborator

pirate-bot commented Sep 27, 2023

Plugin build for 81cb45f is ready 🛎️!

Copy link
Member

@HardeepAsrani HardeepAsrani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to confirm, did you test to confirm this passes the a11y test? In my view, the problem was coming from the lack of ← in the aria-label, but you can correct me if I'm wrong.

@cristian-ungureanu
Copy link
Contributor Author

The error says that "Visible text labels that do not match the accessible name can result in a confusing experience for screen reader users."
That means that the aria-label is not the same as the content of the link. The solution was tested. Also tested your suggestion and the issue remains https://vertis.d.pr/i/hYjdvP

@rodica-andronache
Copy link
Contributor

@cristian-ungureanu tested and everything is working well 👍

@cristian-ungureanu cristian-ungureanu merged commit 27be106 into development Oct 5, 2023
@cristian-ungureanu cristian-ungureanu deleted the fix/accessibility-issue branch October 5, 2023 08:41
@pirate-bot
Copy link
Collaborator

🎉 This PR is included in version 3.7.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-checklist-complete The Pull Request checklist is complete. (automatic label) pr-checklist-skip Allow this Pull Request to skip checklist. released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Accessibility: Elements with visible text labels do not have matching accessible names
4 participants