Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tear down test for rows created with haveInDatabaseon a table without auto increment #59

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

JesusTheHun
Copy link
Contributor

  1. Test rows created with haveInDatabase are correctly deleted during tear down if the table has no auto increment at all
  2. Uniformise database connection by consistently using MYSQL_DSN instead of a combination of MYSQL_HOST and string template.
  3. Swap MariaDB 10.5 for Mysql 5.7 in docker-compose.yml to be coherent with CI.
  4. Create a non-root user in the Dockerfile.php81 to follow composer security guidelines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants