Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python plotly funnel #5298

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Python plotly funnel #5298

wants to merge 7 commits into from
+90 −0

Conversation

ebikatsudon
Copy link
Contributor

Description

Created term entry for the .funnel() method in Python Plotly Express module. Also added images docs\media\plotly-express-funnel-example1.png and docs\media\plotly-express-funnel-example2.png

Issue Solved

Closes #5172

Type of Change

  • Adding a new entry
  • Updating the documentation

Checklist

  • All writings are my own.
  • My entry follows the Codecademy Docs style guide.
  • My changes generate no new warnings.
  • I have performed a self-review of my own writing and code.
  • I have checked my entry and corrected any misspellings.
  • I have made corresponding changes to the documentation if needed.
  • I have confirmed my changes are not being pushed from my forked main branch.
  • I have confirmed that I'm pushing from a new branch named after the changes I'm making.
  • I have linked any issues that are relevant to this PR in the Issues Solved section.

@SaviDahegaonkar SaviDahegaonkar self-assigned this Sep 24, 2024
@SaviDahegaonkar SaviDahegaonkar added python Python entries new entry New entry or entries status: under review Issue or PR is currently being reviewed plotly Python:Plotly entries labels Sep 24, 2024
SaviDahegaonkar
SaviDahegaonkar requested changes Sep 24, 2024
View reviewed changes
Copy link
Collaborator

@SaviDahegaonkar SaviDahegaonkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ebikatsudon ,
The entry LGTM, I have suggested a change please make it asap.

Thanks,
Savi

content/plotly/concepts/express/terms/funnel/funnel.md Outdated Show resolved Hide resolved
@ebikatsudon @SaviDahegaonkar
Update content/plotly/concepts/express/terms/funnel/funnel.md
6edf206 
added backticks around method name

Co-authored-by: Savi Dahegaonkar <[email protected]>
@ebikatsudon
Copy link
Contributor Author

Hi @SaviDahegaonkar, thank you for your review! I have made and committed the change you suggested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SaviDahegaonkar SaviDahegaonkar SaviDahegaonkar requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@SaviDahegaonkar SaviDahegaonkar

Labels
new entry New entry or entries plotly Python:Plotly entries python Python entries status: review 1️⃣ completed status: waiting for author
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Term Entry] Python Plotly - express .funnel()
2 participants
@ebikatsudon @SaviDahegaonkar