Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a fallback font stack for emojis #877

Merged
merged 1 commit into from
Aug 23, 2024
Merged

Conversation

SallyMcGrath
Copy link
Member

@SallyMcGrath SallyMcGrath commented Aug 16, 2024

What does this change?

Common Theme?

adds an explicit fallback stack of emoji fonts
then assigns that to c.emoji

a gesture towards
Issue number #867

Checklist

Who needs to know about this?

Copy link

netlify bot commented Aug 16, 2024

Deploy Preview for cyf-piscine canceled.

Name Link
🔨 Latest commit a75c9c4
🔍 Latest deploy log https://app.netlify.com/sites/cyf-piscine/deploys/66bf3ff68504570008a76829

Copy link

netlify bot commented Aug 16, 2024

Deploy Preview for cyf-programming canceled.

Name Link
🔨 Latest commit a75c9c4
🔍 Latest deploy log https://app.netlify.com/sites/cyf-programming/deploys/66bf3ff65c95ca0008d0ef33

Copy link

netlify bot commented Aug 16, 2024

Deploy Preview for cyf-sdc canceled.

Name Link
🔨 Latest commit a75c9c4
🔍 Latest deploy log https://app.netlify.com/sites/cyf-sdc/deploys/66bf3ff664889d0008f0835d

Copy link

netlify bot commented Aug 16, 2024

Deploy Preview for cyf-common canceled.

Name Link
🔨 Latest commit a75c9c4
🔍 Latest deploy log https://app.netlify.com/sites/cyf-common/deploys/66bf3ff6a6838e0008943a1c

Copy link

netlify bot commented Aug 16, 2024

Deploy Preview for cyf-curriculum ready!

Name Link
🔨 Latest commit a75c9c4
🔍 Latest deploy log https://app.netlify.com/sites/cyf-curriculum/deploys/66bf3ff61757320008e25ec1
😎 Deploy Preview https://deploy-preview-877--cyf-curriculum.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (🟢 up 1 from production)
Accessibility: 98 (no change from production)
Best Practices: 92 (no change from production)
SEO: 82 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Aug 16, 2024

Deploy Preview for cyf-launch canceled.

Name Link
🔨 Latest commit a75c9c4
🔍 Latest deploy log https://app.netlify.com/sites/cyf-launch/deploys/66bf3ff62325cc0008903bfb

Copy link

netlify bot commented Aug 16, 2024

Deploy Preview for cyf-tracks canceled.

Name Link
🔨 Latest commit a75c9c4
🔍 Latest deploy log https://app.netlify.com/sites/cyf-tracks/deploys/66bf3ff640b892000895a41e

@SallyMcGrath SallyMcGrath merged commit e8be388 into main Aug 23, 2024
30 checks passed
@SallyMcGrath SallyMcGrath deleted the bugfix/emoji-fallbacks branch August 23, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant