Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP]: Refactor: remove jQuery as dependency #603

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

JPeer264
Copy link

@JPeer264 JPeer264 commented Jan 25, 2019

As I saw in #570 the discussion was open to remove jQuery as dependency. I made just a first step and removed jQuery from the selectors. There are still no transitions made (so all functions with fadeIn or fadeOut are just commented out).

I wonder if this PR has potential to be merged if, of course, everything works as before, just without jQuery. This actually needs another export function, a global variable or build step (maybe TS?) to make it work in older browsers or course.

Small hint:
For a better diff just add ?w=1

@JPeer264
Copy link
Author

JPeer264 commented Feb 4, 2019

For all who wants to use Toastr without jQuery. I forked the lib and rewrote so it can be used without jQuery (with Typescript support).

NPM: https://www.npmjs.com/package/toastr2
GH: https://github.com/JPeer264/toastr

@colonelchlorine
Copy link

@JPeer264 Is it still forked because there's not much interest here? I was just about to start stripping $ from this library and then bumped into this PR. I'll check it out tomorrow, but excited.

@JPeer264
Copy link
Author

Hey. Ya it is still forked, but I didnt really finish the fork yet, as the animations are missing .

@colonelchlorine
Copy link

@JPeer264 Took a look at changes and there's a bunch of npm packages that are not rly comfortable. For example husky installs a series of git hooks. They could be doing anything to your machine, and I don't trust that :(

@JPeer264
Copy link
Author

Hm I am super sorry about that. But this is actually the workflow I use to ensure code quality. I just use a pre-commit hook for eslint. Locally you could remove that package and develop without it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants