Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Account Management page created #238

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Conversation

c-malecki
Copy link
Member

Description

Account Manager Page added.

Allows end user to update account information such as:

  1. Display Name
  2. Phone Number
  3. Email

Related PRs

none

Related Issues

#99

Todos

  • Tests
  • Documentation

Impacted Areas in Application

New client-side route added, /settings/account, accessible via user dropdown in navigation.

image

Questions For Improvements/Requirements:

  • What fields should be accessible and editable via account settings? displayName, email, and phone are the main ones I saw via requesting /user/{email}.
  • Does giving a user the ability to change their email mess up any other related data within the system?
  • Should the Display Name be a required field, and if so, should it have validations for a minimum character limit as well as special characters?
  • Upon successful submission, user is pushed back to /dashboard - should there be a confirmation message instead and allow them to navigate elsewhere on their own?
  • Should a user be able to remove their phone number via deleting the contents for the phone input and submitting whatever the API's requirement is? (null or empty string?)
  • Should the URL for accessing this page not be a child route of /settings since there is no actual /settings page currently?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant