Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ft/climatemapped-improvements #991

Merged
merged 28 commits into from
Nov 13, 2024
Merged

Conversation

kelvinkipruto
Copy link
Contributor

@kelvinkipruto kelvinkipruto commented Nov 6, 2024

Description

This PR makes several improvements to ClimateMapped

  1. Visual Changes
    1. Improve the DropdownSearch visual look
    2. Hide the tutorial icon if the tutorial is not enabled
  2. CMS Changes
    1. Allow a user to provide the HURUMap backend URL
    2. Allow a user to select which profile to use
    3. Remove Root Geography validation. Since it is a controlled select, we will always be sure about the value. This also improves the speed of the page by reducing API calls.

Fixes #994 #995

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Screenshots

image
image

image

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

@kelvinkipruto kelvinkipruto marked this pull request as ready for review November 8, 2024 10:41
Copy link
Contributor

@koechkevin koechkevin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kelvinkipruto This doesn't run locally, I get this error
image

@kelvinkipruto
Copy link
Contributor Author

@koechkevin You have to login to the admin and add a URL in HURUmap settings

Copy link
Member

@kilemensi kilemensi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽 ... not too sure about the code structure though.

@kilemensi
Copy link
Member

I also see function parameters named BASE_URL @kelvinkipruto...

@kelvinkipruto
Copy link
Contributor Author

I also see function parameters named BASE_URL

Resolved @kilemensi

@kelvinkipruto kelvinkipruto requested a review from m453h November 13, 2024 09:39
@kelvinkipruto kelvinkipruto added this pull request to the merge queue Nov 13, 2024
Merged via the queue into main with commit 8d5860e Nov 13, 2024
4 checks passed
@kelvinkipruto kelvinkipruto deleted the ft/climatemapped-improvements branch November 13, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Search Field adjustments/corrections - #ClimateMap
4 participants