Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ft/climatemapped-build-fix #988

Merged
merged 9 commits into from
Nov 6, 2024
Merged

Ft/climatemapped-build-fix #988

merged 9 commits into from
Nov 6, 2024

Conversation

kelvinkipruto
Copy link
Contributor

@kelvinkipruto kelvinkipruto commented Nov 5, 2024 •
edited by koechkevin
Loading

Description

This PR

  • Updates hero map component to ensure no hover effects/ click actions on map if hurumap is disabled in settings.
  • Fixes a breaking build on hero if hurumap settings is not updated

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Screenshots

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

@koechkevin koechkevin mentioned this pull request Nov 5, 2024
Merged
8 tasks
@koechkevin koechkevin marked this pull request as ready for review November 5, 2024 13:52
@koechkevin koechkevin self-assigned this Nov 5, 2024
@koechkevin koechkevin requested a review from a team November 5, 2024 13:53
kilemensi
kilemensi reviewed Nov 6, 2024
View reviewed changes
Copy link
Member

@kilemensi kilemensi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽

  1. Please update the PR description
  2. There is an open PR for building images. Enabling build on every PR will lead to merging unwanted code to main.

apps/climatemappedafrica/src/lib/data/blockify/hero.js Outdated Show resolved Hide resolved
@koechkevin koechkevin requested a review from kilemensi November 6, 2024 07:26
@kelvinkipruto kelvinkipruto added this pull request to the merge queue Nov 6, 2024
Merged via the queue into main with commit d5127f2 Nov 6, 2024
4 checks passed
@kelvinkipruto kelvinkipruto deleted the ft/climatemapped-build-fix branch November 6, 2024 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koechkevin koechkevin koechkevin approved these changes

@kilemensi kilemensi kilemensi approved these changes

Assignees

@koechkevin koechkevin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kelvinkipruto @kilemensi @koechkevin