Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ClimateMapped Fixes #982

Merged
merged 14 commits into from
Nov 1, 2024
Merged

ClimateMapped Fixes #982

merged 14 commits into from
Nov 1, 2024

Conversation

kelvinkipruto
Copy link
Contributor

@kelvinkipruto kelvinkipruto commented Oct 29, 2024 •
edited
Loading

Description

This PR fixes a few bugs on ClimateMappedAfrica:

  1. Searching for locations now works
  2. How it works Moblie view How it Works Mobile View #974
  3. Navigation between regions not working From Country to regional navigation #966

Fixes #974

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Screenshots

image
image

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

@kelvinkipruto kelvinkipruto marked this pull request as ready for review October 30, 2024 12:36
@kelvinkipruto
Revert Workflow file
b2a7d03 
Signed-off-by: Kipruto <[email protected]>
kilemensi
kilemensi reviewed Oct 30, 2024
View reviewed changes
Copy link
Member

@kilemensi kilemensi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll let others do a deeper review but aren't we calling fetchProfile too many times? In getNavBar, blockify, etc.

If it's HURUmap profile page, profile should be loaded just once (in the lib/data/common.js?) and passed to all relevant functions/blocks.

kilemensi
kilemensi approved these changes Oct 31, 2024
View reviewed changes
Copy link
Member

@kilemensi kilemensi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM!

apps/climatemappedafrica/src/components/HowItWorks/index.js Outdated Show resolved Hide resolved
apps/climatemappedafrica/src/components/Navigation/ExploreNavigation/index.js Show resolved Hide resolved
apps/climatemappedafrica/src/lib/data/blockify/index.js Outdated Show resolved Hide resolved
@kelvinkipruto kelvinkipruto added this pull request to the merge queue Nov 1, 2024
Merged via the queue into main with commit 1e2af03 Nov 1, 2024
4 checks passed
@kelvinkipruto kelvinkipruto deleted the ft/climatemapped-hurumap-fixes branch November 1, 2024 04:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kilemensi kilemensi kilemensi approved these changes

@koechkevin koechkevin koechkevin approved these changes

@m453h m453h Awaiting requested review from m453h

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

How it Works Mobile View
3 participants
@kelvinkipruto @kilemensi @koechkevin