Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIxed Hero Mobile styles. #979

Merged
merged 5 commits into from
Oct 28, 2024
Merged

FIxed Hero Mobile styles. #979

merged 5 commits into from
Oct 28, 2024

Conversation

koechkevin
Copy link
Contributor

@koechkevin koechkevin commented Oct 25, 2024 •
edited
Loading

Removed useStyles in Dropdown Search

Description

This PR fixes styling issues on Hero Component

Fixes #975

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Screenshots

image image

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

@koechkevin
FIxed Hero Mobile styles.
81ac2ac 
Removed useStyles in Dropdown Search
@koechkevin koechkevin self-assigned this Oct 25, 2024
@koechkevin koechkevin requested a review from a team October 25, 2024 14:07
@kilemensi
Copy link
Member

In desktop, why doesn't the hero align with the navbar? Feels like there is extra left/right margin/padding added.

@koechkevin
Copy link
Contributor Author

In desktop, why doesn't the hero align with the navbar? Feels like there is extra left/right margin/padding added.

Updated!

kilemensi
kilemensi approved these changes Oct 25, 2024
View reviewed changes
Copy link
Member

@kilemensi kilemensi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't run it locally but code LGTM!

apps/climatemappedafrica/src/components/Hero/Hero.js Outdated Show resolved Hide resolved
@koechkevin koechkevin added this pull request to the merge queue Oct 28, 2024
Merged via the queue into main with commit 18d75cb Oct 28, 2024
4 checks passed
@koechkevin koechkevin deleted the chore/hero-mobile-fix branch October 28, 2024 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kelvinkipruto kelvinkipruto kelvinkipruto approved these changes

@kilemensi kilemensi kilemensi approved these changes

Assignees

@koechkevin koechkevin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hero Mobile View
3 participants
@koechkevin @kilemensi @kelvinkipruto