Charter Africa Design Update

[kelvinkipruto]

Description

This PR makes updates to the Datasets and Contributors pages as per the new designs here and here.

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)

Screenshots

Datasets Page

Contributors Page

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation

[kilemensi]

Didn't we use to have dev urls to see how the PR looks live @kelvinkipruto?

[kelvinkipruto]

@kilemensi That was only for codeforafrica. It does not work for any of the other apps.

[kilemensi]

👍🏽

---

1. With these additional API calls, are we still within the limits?
2. Has the dev DB been setup correctly so that if this PR has been merged, we can ask for review on dev site before deploying to prod?

[kilemensi]

@koechkevin

[koechkevin]

@kelvinkipruto I have run the script locally and did not see the updated changes on contributor.

Can we catch up on this?

[kilemensi]

@kelvinkipruto I have run the script locally and did not see the updated changes on contributor.

Can we catch up on this?

Is this issue resolve @koechkevin / @kelvinkipruto ?

[koechkevin]

@kelvinkipruto implementation looks good, however I notice 2 things.

1. The token will need to be updated with a token with sufficient organisation scope permission.
2. Looks like with payload version 2, setting limit to 0 on payload.find no longer gets all the collection items but rather 10 and not all entries will get updated when the cron runs.

[kilemensi]

2. Looks like with payload version 2, setting limit to 0 on `payload.find` no longer gets all the collection items but rather 10 and not all entries will get updated when the cron runs.

Are you talking about disabling pagination @koechkevin ?

[koechkevin]

2. Looks like with payload version 2, setting limit to 0 on `payload.find` no longer gets all the collection items but rather 10 and not all entries will get updated when the cron runs.

Are you talking about disabling pagination @koechkevin ?

Yes @kilemensi

[kilemensi]

👍🏽

--

1. Rename the icons to follow the current naming scheme. It allows us to see the size, color, etc., of the icon at a glance without opening it.
2. I see some of the icons have different size/viewBox e.g. discord is 25/"0 0 25 25". If an icon size is not 24 (the default in MUI), you must set viewBox prop on the SVGIcon component so that MUI scales it accordingly.

[koechkevin]

@kilemensi an update on this.

Using github graphql to fetch a user causes the script to exceed github's rate limits.
Thinking out a workaround for this is bulkfetch all the users in a single graphql query together with aliases which works upto around 100 contributors after which github's server times out.

The only part remaining on this PR

[kilemensi]

Using github graphql to fetch ...
The only part remaining on this PR

Thanks for double-checking this @koechkevin. Lets pick this up tomorrow when @kelvinkipruto is back to hear if he has a plan to deal with this issue or not.

[koechkevin]

@kelvinkipruto check on this push to reduce API calls to github

[kelvinkipruto]

@koechkevin Looks good. I have made a few updates to it.

[kilemensi]

👍🏽

--

1. Rename the icons to follow the current naming scheme. It allows us to see the size, color, etc., of the icon at a glance without opening it.
2. I see some of the icons have different size/viewBox e.g. discord is 25/"0 0 25 25". If an icon size is not 24 (the default in MUI), you must set viewBox prop on the SVGIcon component so that MUI scales it accordingly.

Have these been addressed @kelvinkipruto ?

[kelvinkipruto]

@kilemensi Updated.

[kilemensi]

🚀

---

Lets deploy this to dev but still not happy with the code... something are supposed to be card but they're not, they way we're handling viewBox, etc.