Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix @/charterafrica security issue #624

Merged
merged 3 commits into from
Oct 4, 2023
Merged

Fix @/charterafrica security issue #624

merged 3 commits into from
Oct 4, 2023

Conversation

kilemensi
Copy link
Member

@kilemensi kilemensi commented Oct 4, 2023 •
edited
Loading

Description

Current draft mode implementation redirects to the requested slug without ensuring that the slug points to a page on the charterAFRICA site. This can lead to open redirect vulnerabilities. This PR fixes that.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Screenshots

N/A

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas

@kilemensi kilemensi added the bug Something isn't working label Oct 4, 2023
@kilemensi kilemensi self-assigned this Oct 4, 2023
@kilemensi kilemensi added this pull request to the merge queue Oct 4, 2023
Merged via the queue into main with commit aa24ccd Oct 4, 2023
2 checks passed
@kilemensi kilemensi deleted the fix/charterafrica_draft_mode branch October 4, 2023 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kelvinkipruto kelvinkipruto kelvinkipruto approved these changes

@koechkevin koechkevin koechkevin approved these changes

Assignees

@kilemensi kilemensi

Labels
bug Something isn't working
Projects
COMMONS
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kilemensi @koechkevin @kelvinkipruto