Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review of @/codeforafrica CMS #619

Merged
merged 19 commits into from
Oct 4, 2023
Merged

Review of @/codeforafrica CMS #619

merged 19 commits into from
Oct 4, 2023

Conversation

kilemensi
Copy link
Member

Description

As we prepare to hand over the CMS to the content team, this PR reviews the current state of the CMS and makes necessary adjustments. Things that this PR addressed include:

  • Admin organisation: Moving away from non-descriptive Collections/Globals into Publication, Organisation and Website (more ideas are welcome as always),
  • Custom users and emails: We should be able to define roles as well as allow users to reset their passwords etc.
  • Enables localisation: While not used, it's important to enable it now when we don't have any content yet rather than in the future where we may have to create complex content migration scripts.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Screenshots

Screenshot 2023-10-03 at 16-42-36 Editing - User - Payload

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas

@kilemensi kilemensi added bug Something isn't working chore A task that needs to be done (neither enhancement or bug) enhancement New feature or request dependencies labels Oct 3, 2023
@kilemensi kilemensi self-assigned this Oct 3, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 3, 2023

Latest updated Preview URL

Name Review
codeforafrica-ui-pr-619 Visit

@kilemensi
Copy link
Member Author

@kelvinkipruto ?

kelvinkipruto
kelvinkipruto approved these changes Oct 4, 2023
View reviewed changes
Copy link
Contributor

@kelvinkipruto kelvinkipruto left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good.
One small issue when creating a new user, we have to reselect the role as the default one throws an error users validation failed: roles: Cast to string failed for value \"[ 'editor' ]\" (type Array) at path \"roles\""
Another issue we can maybe look into in future is if a user has not been verified, it throws wrong credential error. A better error message would be to tell them to verify their email.

@kilemensi kilemensi merged commit 12ef998 into develop Oct 4, 2023
@kilemensi kilemensi deleted the fix/codeforafrica_cms branch October 4, 2023 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koechkevin koechkevin koechkevin approved these changes

@kelvinkipruto kelvinkipruto kelvinkipruto approved these changes

Assignees

@kilemensi kilemensi

Labels
bug Something isn't working chore A task that needs to be done (neither enhancement or bug) dependencies enhancement New feature or request
Projects
COMMONS
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kilemensi @koechkevin @kelvinkipruto