Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ecosystem filters. #618

Merged
merged 2 commits into from
Oct 3, 2023
Merged

Fix ecosystem filters. #618

merged 2 commits into from
Oct 3, 2023

Conversation

koechkevin
Copy link
Contributor

@koechkevin koechkevin commented Oct 3, 2023

Description

This PR fixes filters on Ecosystem list
Location and theme missing on query to filter.
Fixes blank page issue when list is empty.

Fixes #603

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Screenshots

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

- Search by location not working.
- On Empty list, blank page shown
@koechkevin koechkevin self-assigned this Oct 3, 2023
@kilemensi
Copy link
Member

Can you summarise what was the actual issue @koechkevin (besides the blank screen)?

Your review @kelvinkipruto

@koechkevin koechkevin added this pull request to the merge queue Oct 3, 2023
Merged via the queue into main with commit ac3b62f Oct 3, 2023
2 checks passed
@koechkevin koechkevin deleted the bug/fix-charterafrica-filter branch October 3, 2023 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@/charterafrica Filter tools, contributors, organisation
3 participants