Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add members single Page View #611

Merged
merged 4 commits into from
Sep 27, 2023
Merged

Add members single Page View #611

merged 4 commits into from
Sep 27, 2023

Conversation

koechkevin
Copy link
Contributor

@koechkevin koechkevin commented Sep 26, 2023 •
edited
Loading

Description

This PR implement Single member page view by using the same component with Partners View

Fixes #602

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Screenshots

image

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

@koechkevin koechkevin self-assigned this Sep 26, 2023
@github-actions
Copy link
Contributor

Latest updated Preview URL

Name Review
codeforafrica-ui-pr-611 Visit

@koechkevin koechkevin changed the title Add single Page View Add members single Page View Sep 26, 2023
kelvinkipruto
kelvinkipruto reviewed Sep 27, 2023
View reviewed changes
Copy link
Contributor

@kelvinkipruto kelvinkipruto left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@koechkevin When clicking on a user in the list, it does not redirect to the user details page

apps/codeforafrica/src/lib/data/pagify/members.js Show resolved Hide resolved
apps/codeforafrica/src/lib/data/pagify/index.js Outdated Show resolved Hide resolved
kelvinkipruto
kelvinkipruto approved these changes Sep 27, 2023
View reviewed changes
Copy link
Contributor

@kelvinkipruto kelvinkipruto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@koechkevin koechkevin merged commit 2cae54d into develop Sep 27, 2023
4 checks passed
@koechkevin koechkevin deleted the feature/single-member-page-view branch September 27, 2023 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kelvinkipruto kelvinkipruto kelvinkipruto approved these changes

@kilemensi kilemensi Awaiting requested review from kilemensi

Assignees

@koechkevin koechkevin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@koechkevin @kelvinkipruto