Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Guiding Principles #600

Merged
merged 4 commits into from
Sep 22, 2023
Merged

Add Guiding Principles #600

merged 4 commits into from
Sep 22, 2023

Conversation

koechkevin
Copy link
Contributor

@koechkevin koechkevin commented Sep 21, 2023 •
edited
Loading

Description

Adds Guiding Principles

Fixes #599

Type of change

  • New feature (non-breaking change which adds functionality)

Screenshots

image image image

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

@koechkevin koechkevin self-assigned this Sep 21, 2023
@koechkevin koechkevin marked this pull request as draft September 21, 2023 09:11
@github-actions
Copy link
Contributor

Latest updated Preview URL

Name Review
codeforafrica-ui-pr-600 Visit

@koechkevin koechkevin changed the title Add Guiding Princiles Add Guiding Principles Sep 21, 2023
@koechkevin koechkevin marked this pull request as ready for review September 21, 2023 10:40
kilemensi
kilemensi reviewed Sep 21, 2023
View reviewed changes
apps/codeforafrica/src/components/GuidingPrinciplesCardList/GuidingPrinciplesCardList.js Show resolved Hide resolved
apps/codeforafrica/src/payload/blocks/GuidingPrinciples.js Show resolved Hide resolved
apps/codeforafrica/src/payload/collections/Media.js
@@ -18,6 +18,9 @@ const Media = {
required: true,
},
],
hooks: {
afterRead: [({ doc }) => ({ ...doc, src: doc.url })],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@koechkevin koechkevin merged commit 488a9a9 into develop Sep 22, 2023
@koechkevin koechkevin deleted the feature/guiding-principles-cfa branch September 22, 2023 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kilemensi kilemensi kilemensi approved these changes

@kelvinkipruto kelvinkipruto Awaiting requested review from kelvinkipruto

Assignees

@koechkevin koechkevin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@koechkevin @kilemensi