Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ft/codeforafrica Impact collection #594

Merged
merged 6 commits into from
Sep 20, 2023
Merged

Ft/codeforafrica Impact collection #594

merged 6 commits into from
Sep 20, 2023

Conversation

kelvinkipruto
Copy link
Contributor

@kelvinkipruto kelvinkipruto commented Sep 19, 2023 •
edited
Loading

Description

This PR implements impact collection.

Fixes #564

Type of change

  • New feature (non-breaking change which adds functionality)

Screenshots

image

image

image

image

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

@kelvinkipruto kelvinkipruto marked this pull request as ready for review September 19, 2023 11:18
kilemensi
kilemensi reviewed Sep 19, 2023
View reviewed changes
Copy link
Member

@kilemensi kilemensi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build is failing

apps/codeforafrica/src/payload/collections/Impact.js Outdated Show resolved Hide resolved
apps/codeforafrica/src/payload/fields/impacts.js Show resolved Hide resolved
kilemensi
kilemensi approved these changes Sep 19, 2023
View reviewed changes
Copy link
Member

@kilemensi kilemensi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@kelvinkipruto kelvinkipruto merged commit ef2435c into develop Sep 20, 2023
@kelvinkipruto kelvinkipruto deleted the ft/codeforafrica-impact branch September 20, 2023 06:33
@kilemensi kilemensi mentioned this pull request Sep 20, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kilemensi kilemensi kilemensi approved these changes

@koechkevin koechkevin Awaiting requested review from koechkevin

@saminegash saminegash Awaiting requested review from saminegash

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kelvinkipruto @kilemensi