Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Page SEO #583

Merged
merged 29 commits into from
Sep 22, 2023
Merged

Add Page SEO #583

merged 29 commits into from
Sep 22, 2023

Conversation

kelvinkipruto
Copy link
Contributor

@kelvinkipruto kelvinkipruto commented Sep 14, 2023 •
edited
Loading

Description

This PR adds individual Page SEO. This PR does not handle SEO for nested pages. This will be handled by #584

Fixes #562

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

@kelvinkipruto kelvinkipruto marked this pull request as ready for review September 14, 2023 10:22
@github-actions
Copy link
Contributor

Latest updated Preview URL

Name Review
codeforafrica-ui-pr-583 Visit

kilemensi
kilemensi reviewed Sep 15, 2023
View reviewed changes
Copy link
Member

@kilemensi kilemensi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽

There is a way we're handling alternative hrefs or urls in SEO and I don't see it here. Is it because we don't support localisation?

apps/codeforafrica/src/lib/data/rest/index.js Outdated Show resolved Hide resolved
apps/codeforafrica/src/lib/data/seo.js Outdated Show resolved Hide resolved
apps/codeforafrica/src/lib/data/seo.js Outdated Show resolved Hide resolved
apps/codeforafrica/src/lib/data/seo.js Outdated Show resolved Hide resolved
@kelvinkipruto
Copy link
Contributor Author

There is a way we're handling alternative hrefs or urls in SEO and I don't see it here. Is it because we don't support localisation?

@kilemensi, Yes. We do not support localisation yet.

@kelvinkipruto
Copy link
Contributor Author

@kilemensi @koechkevin This is ready

@kilemensi
Copy link
Member

Can we update this PR @kelvinkipruto ?

@kelvinkipruto
Copy link
Contributor Author

@kilemensi updated

@kelvinkipruto kelvinkipruto merged commit 5ed3200 into develop Sep 22, 2023
4 checks passed
@kelvinkipruto kelvinkipruto deleted the ft/codeforafrica-seo branch September 22, 2023 09:08
@kelvinkipruto kelvinkipruto mentioned this pull request Sep 22, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koechkevin koechkevin koechkevin approved these changes

@kilemensi kilemensi kilemensi approved these changes

@saminegash saminegash Awaiting requested review from saminegash

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kelvinkipruto @kilemensi @koechkevin