Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to the new standard schema #579

Merged
merged 3 commits into from
Sep 15, 2023
Merged

Conversation

koechkevin
Copy link
Contributor

Description

This PR updates charter africa to use new standard schema.
As per discussion and test of the originally implemented schema, the difference in time/size is negligible.

Fixes #559

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Screenshots

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

@koechkevin koechkevin self-assigned this Sep 11, 2023
@koechkevin koechkevin added the enhancement New feature or request label Sep 11, 2023
@kilemensi
Copy link
Member

Is this a test or a migration to the new schema @koechkevin ?

@koechkevin
Copy link
Contributor Author

Is this a test or a migration to the new schema @koechkevin ?

This is a migration.

@koechkevin koechkevin changed the title Test new standard schema Migrate to the new standard schema Sep 12, 2023
Copy link
Member

@kilemensi kilemensi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽


Only done a quick review, I'm sure the rest of the team will do a more thorough review.

I've also noticed two files: airtable.old.js and ecostystem.old.js in the lib/ecosystem folder. Are they still being used or are they just on my local machine?

@kelvinkipruto
Copy link
Contributor

@koechkevin When updating the Contributors' Table, Telegram social media does not appear in the dropdown list.

@koechkevin
Copy link
Contributor Author

@koechkevin When updating the Contributors' Table, Telegram social media does not appear in the dropdown list.

@kelvinkipruto then the column does not exist in airtable. Not a code problem

@koechkevin koechkevin added this pull request to the merge queue Sep 15, 2023
Merged via the queue into main with commit 6cf4530 Sep 15, 2023
@koechkevin koechkevin deleted the feature/test-standard-schema branch September 15, 2023 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Charter Africa | Test Airtable New Airtable Schema
3 participants