Remove static props and fix layout #578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why are you pinging me to review a page that's still in draft @kelvinkipruto ? |
|
Latest updated Preview URL
|
|
@kilemensi Sorry. It's now ready. |
kilemensi
reviewed
Sep 11, 2023
There was a problem hiding this comment.
👍🏽
I'm a bit lost: Why does lib/data/local use api from lib/data/rest? My understanding is lib/data/local should be using local payload while lib/data/rest should be using REST APIs.
At least this is how code is structured in app/charterafrica. What has channged?
kilemensi
added
the
chore
kilemensi
reviewed
Sep 12, 2023
koechkevin
approved these changes
Sep 12, 2023
kilemensi
approved these changes
Sep 12, 2023
Comment on lines
8
to
9
| // eslint-disable-next-line react/jsx-no-useless-fragment | ||
| <> |
There was a problem hiding this comment.
Looks like we don't need a div or <>. What happens when you remove them completely?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes static props used previously and fixes page layouts.
Type of change
Checklist: