Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove useStyles from Components #1010

Merged
merged 16 commits into from
Dec 13, 2024
Merged

Remove useStyles from Components #1010

merged 16 commits into from
Dec 13, 2024

Conversation

kelvinkipruto
Copy link
Contributor

@kelvinkipruto kelvinkipruto commented Dec 5, 2024 •
edited
Loading

Description

This PR removes useStyles from the rest of components

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Screenshots

image
image
image
image

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

@kelvinkipruto kelvinkipruto marked this pull request as ready for review December 5, 2024 11:51
@koechkevin
Copy link
Contributor

@kelvinkipruto I still see references for useStyles in apps/climatemappedafrica/src/components/Section/index.js anf Footer

@kelvinkipruto
Copy link
Contributor Author

kelvinkipruto commented Dec 5, 2024 •
edited
Loading

still see references for useStyles in apps/climatemappedafrica/src/components/Section/index.js anf Footer

@koechkevin . Yes. These components use the old commons-ui package from NPM. Once this is merged, we will remove those components.

@kilemensi
Copy link
Member

kilemensi commented Dec 12, 2024 •
edited
Loading

I'm seeing 👇🏽 issue on Navbar
Screenshot 2024-12-12 at 08 36 46
Screenshot 2024-12-12 at 08 37 20

@kelvinkipruto kelvinkipruto added this pull request to the merge queue Dec 13, 2024
Merged via the queue into main with commit 41f5cdc Dec 13, 2024
4 checks passed
@kelvinkipruto kelvinkipruto deleted the ft/remove-useStyle-from-components branch December 13, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koechkevin koechkevin koechkevin approved these changes

@kilemensi kilemensi Awaiting requested review from kilemensi

@m453h m453h Awaiting requested review from m453h

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kelvinkipruto @koechkevin @kilemensi