Skip to content

Commit

Permalink
Completely remove HURUMAP_API_URL from Docker build workflows
Browse files Browse the repository at this point in the history
  • Loading branch information
kilemensi committed Nov 20, 2024
1 parent dae7ccb commit bc7e23b
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 6 deletions.
1 change: 0 additions & 1 deletion .github/workflows/climatemappedafrica-deploy-dev.yml
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,6 @@ jobs:
uses: docker/build-push-action@v3
with:
build-args: |
HURUMAP_API_URL=${{ secrets.CLIMATEMAPPEDAFRICA_HURUMAP_API_URL }}
MONGO_URL=${{ secrets.CLIMATEMAPPEDAFRICA_MONGO_URL }}
NEXT_PUBLIC_APP_URL=${{ env.NEXT_PUBLIC_APP_URL }}
PAYLOAD_SECRET=${{ secrets.CLIMATEMAPPEDAFRICA_PAYLOAD_SECRET }}
Expand Down
4 changes: 1 addition & 3 deletions Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -387,9 +387,7 @@ ARG NEXT_TELEMETRY_DISABLED \
SENTRY_AUTH_TOKEN \
SENTRY_ENVIRONMENT \
SENTRY_ORG \
SENTRY_PROJECT \
# Custom (runtime)
HURUMAP_API_URL
SENTRY_PROJECT

# This is in app-builder instead of base-builder just incase app-deps adds deps
COPY --from=climatemappedafrica-deps /workspace/node_modules ./node_modules
Expand Down
2 changes: 0 additions & 2 deletions docker-compose.yml
Original file line number Diff line number Diff line change
Expand Up @@ -82,14 +82,12 @@ services:
context: .
target: climatemappedafrica-runner
args:
- HURUMAP_API_URL
- MONGO_URL=mongodb://${MONGO_INITDB_ROOT_USERNAME:-root}:${MONGO_INITDB_ROOT_PASSWORD:-rootpassword}@host.docker.internal:${MONGODB_PORT:-27017}/climatemappedafrica?authSource=admin&directConnection=true
- PAYLOAD_SECRET
- SENTRY_ENVIRONMENT
- SENTRY_ORG
- SENTRY_PROJECT
environment:
HURUMAP_API_URL: ${HURUMAP_API_URL}
MONGO_URL: mongodb://${MONGO_INITDB_ROOT_USERNAME:-root}:${MONGO_INITDB_ROOT_PASSWORD:-rootpassword}@host.docker.internal:${MONGODB_PORT:-27017}/climatemappedafrica?authSource=admin&directConnection=true
PAYLOAD_SECRET: ${PAYLOAD_SECRET}
S3_ACCESS_KEY_ID: ${S3_ACCESS_KEY_ID}
Expand Down

0 comments on commit bc7e23b

Please sign in to comment.