Merge pull request #857 from CodeForAfrica/hotfix/civicsignalblog_rob…

…oshield_seo_title_template [Hotfix] SEO title template
CodeForAfrica · Aug 22, 2024 · 8a601b6 · 8a601b6
2 parents ba79ef0 + ff8a781
commit 8a601b6
Show file tree

Hide file tree

Showing 6 changed files with 5 additions and 7 deletions.
diff --git a/apps/civicsignalblog/contrib/dokku/Dockerfile b/apps/civicsignalblog/contrib/dokku/Dockerfile
@@ -1 +1 @@
-FROM codeforafrica/codeforafrica-ui:0.1.12
+FROM codeforafrica/codeforafrica-ui:0.1.13
diff --git a/apps/civicsignalblog/package.json b/apps/civicsignalblog/package.json
@@ -1,6 +1,6 @@
 {
   "name": "civicsignalblog",
-  "version": "0.1.12",
+  "version": "0.1.13",
   "private": true,
   "author": "Code for Africa <[email protected]>",
   "description": "This is the (temporary) CivicSignal blog",

diff --git a/apps/civicsignalblog/src/lib/data/seo.js b/apps/civicsignalblog/src/lib/data/seo.js
@@ -39,8 +39,7 @@ export default function getPageSeoFromMeta(page, settings) {
   const defaultTitle = settings.meta?.title || settings.title || site.name;
   const title = page.meta?.title || page.title || defaultTitle;
   // Dont't use template on homepage
-  const titleTemplate =
-    page.slug !== "index" ? defaultTitle && `%s | ${defaultTitle}` : null;
+  const titleTemplate = page.slug === "index" ? "%s" : `%s | ${defaultTitle}`;
   const description =
     page.meta?.description ||
     settings.meta?.description ||

diff --git a/apps/roboshield/package.json b/apps/roboshield/package.json
@@ -1,6 +1,6 @@
 {
   "name": "roboshield",
-  "version": "0.1.11",
+  "version": "0.1.12",
   "private": true,
   "scripts": {
     "build-server": "tsc --project tsconfig.server.json",

diff --git a/apps/roboshield/public/image.jpg b/apps/roboshield/public/image.jpg
diff --git a/apps/roboshield/src/lib/data/seo.ts b/apps/roboshield/src/lib/data/seo.ts
@@ -66,8 +66,7 @@ export default function getPageSeoFromMeta(
   const defaultTitle = settings.meta?.title || settings.title || site.name;
   const title = page.meta?.title || page.title || defaultTitle;
   // Dont't use template on homepage
-  const titleTemplate =
-    page.slug !== "index" ? defaultTitle && `%s | ${defaultTitle}` : null;
+  const titleTemplate = page.slug === "index" ? "%s" : `%s | ${defaultTitle}`;
   const description =
     page.meta?.description ||
     settings.meta?.description ||
Original file line number	Diff line number	Diff line change
		@@ -1 +1 @@
		FROM codeforafrica/codeforafrica-ui:0.1.12
		FROM codeforafrica/codeforafrica-ui:0.1.13