Skip to content

Commit

Permalink
Review fix
Browse files Browse the repository at this point in the history
  • Loading branch information
kelvinkipruto committed Jul 17, 2024
1 parent c0a0ddf commit 2d5311d
Show file tree
Hide file tree
Showing 7 changed files with 6 additions and 33 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ function KeyMetric({
<Source
href={url}
sx={(theme) => ({
margin: `${theme.typography.pxToRem(20)} 0`,
marginTop: theme.typography.pxToRem(10),
})}
>
{source}
Expand Down
2 changes: 1 addition & 1 deletion apps/pesayetu/src/components/HURUmap/KeyMetric/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ function KeyMetric({
<Source
href={url}
sx={(theme) => ({
margin: `${theme.typography.pxToRem(20)} 0`,
marginTop: `${theme.typography.pxToRem(20)} 0`,
})}
>
{source}
Expand Down
3 changes: 1 addition & 2 deletions packages/hurumap-core/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,6 @@
"react-leaflet": "^4.2.1"
},
"dependencies": {
"prop-types": "^15.8.1",
"@commons-ui/next": "workspace:*"
"prop-types": "^15.8.1"
}
}
20 changes: 1 addition & 19 deletions packages/hurumap-next/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,19 +1 @@
# @commons-ui/next

## 2.0.1

### Patch Changes

- [#247](https://github.com/CodeForAfrica/ui/pull/247) [`2a01454`](https://github.com/CodeForAfrica/ui/commit/2a014544fa84b7385cfa9496596699fdd1b3a0ba) Thanks [@kilemensi](https://github.com/kilemensi)! - Fixes playwright e2e testing + standardises SEO titles

- Updated dependencies [[`2a01454`](https://github.com/CodeForAfrica/ui/commit/2a014544fa84b7385cfa9496596699fdd1b3a0ba)]:
- @commons-ui/core@2.0.1

## 2.0.0

### Patch Changes

- [#241](https://github.com/CodeForAfrica/ui/pull/241) [`f792694`](https://github.com/CodeForAfrica/ui/commit/f7926944fb505adaa8905dc8aeba04913f56ea85) Thanks [@kilemensi](https://github.com/kilemensi)! - Improved RichTypography to better handle color and relative links

- Updated dependencies [[`f792694`](https://github.com/CodeForAfrica/ui/commit/f7926944fb505adaa8905dc8aeba04913f56ea85)]:
- @commons-ui/core@2.0.0
# @hurumap/next
2 changes: 0 additions & 2 deletions packages/hurumap-next/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -53,14 +53,12 @@
"@babel/core": "^7.22.9",
"@commons-ui/core": "workspace:*",
"@mui/material": "^5.14.0",
"clsx": "^2.0.0",
"next": "~13.4.11",
"prop-types": "^15.8.1",
"react": "^18.2.0",
"react-dom": "^18.2.0"
},
"dependencies": {
"clsx": "^2.1.1",
"@commons-ui/next": "workspace:*"
}
}
4 changes: 2 additions & 2 deletions packages/hurumap-next/src/Source/Source.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,11 @@ import React from "react";

const Source = React.forwardRef(function Source(
{
LinkProps,
TitleTypographyProps,
children,
href,
title = "Source",
TitleTypographyProps,
LinkProps,
...props
},
ref,
Expand Down
6 changes: 0 additions & 6 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 2d5311d

Please sign in to comment.