chore: Update eslint config and fix relative imports

CodeForAfrica · Dec 2, 2024 · 21a2185 · 21a2185
1 parent 65ca9c4
commit 21a2185
Show file tree

Hide file tree

Showing 23 changed files with 85 additions and 502 deletions.
diff --git a/apps/charterafrica/eslint.config.js b/apps/charterafrica/eslint.config.js
@@ -1,30 +1,6 @@
 const eslintConfig = require("eslint-config-commons-ui/next");
 
 module.exports = [
-  {
-    ignores: [
-      "**/node_modules",
-      "**/.pnp",
-      "**/.pnp.js",
-      "**/.pnpm-debug.log",
-      "**/dist/",
-      "**/coverage",
-      "**/.next/",
-      "**/out/",
-      "**/build/",
-      "**/.DS_Store",
-      "**/*.pem",
-      "**/npm-debug.log*",
-      "**/yarn-debug.log*",
-      "**/yarn-error.log*",
-      "**/.vercel",
-      "**/.now",
-      "**/.turbo",
-      "**/test-results/",
-      "**/playwright-report/",
-      "**/public/",
-    ],
-  },
   {
     settings: {
       "import/resolver": {

diff --git a/apps/civicsignalblog/eslint.config.js b/apps/civicsignalblog/eslint.config.js
@@ -2,45 +2,19 @@ const eslintConfig = require("eslint-config-commons-ui/next");
 
 module.exports = [
   {
-    ignores: [
-      "**/node_modules",
-      "**/.pnp",
-      "**/.pnp.js",
-      "**/.pnpm-debug.log",
-      "**/dist/",
-      "**/coverage",
-      "**/.next/",
-      "**/out/",
-      "**/build/",
-      "**/.DS_Store",
-      "**/*.pem",
-      "**/npm-debug.log*",
-      "**/yarn-debug.log*",
-      "**/yarn-error.log*",
-      "**/.vercel",
-      "**/.now",
-      "**/.turbo",
-      "**/test-results/",
-      "**/playwright-report/",
-    ],
-  },
-  ...eslintConfig.map((config) => {
-    return {
-      ...config,
-      settings: {
-        ...config.settings,
-        "import/resolver": {
-          webpack: {
-            config: "./eslint.webpack.config.js",
-          },
-          typescript: {
-            alwaysTryTypes: false,
-            project: "./tsconfig.json",
-          },
+    settings: {
+      "import/resolver": {
+        webpack: {
+          config: "./eslint.webpack.config.js",
+        },
+        typescript: {
+          alwaysTryTypes: false,
+          project: "./tsconfig.json",
         },
       },
-    };
-  }),
+    },
+  },
+  ...eslintConfig,
   {
     rules: {
       "react/jsx-filename-extension": [1, { extensions: [".js", ".tsx"] }], // This rule allows JSX syntax in both .js and tsx files

diff --git a/apps/climatemappedafrica/eslint.config.js b/apps/climatemappedafrica/eslint.config.js
@@ -1,29 +1,6 @@
 const eslintConfig = require("eslint-config-commons-ui/next");
 
 module.exports = [
-  {
-    ignores: [
-      "**/node_modules",
-      "**/.pnp",
-      "**/.pnp.js",
-      "**/.pnpm-debug.log",
-      "**/dist/",
-      "**/coverage",
-      "**/.next/",
-      "**/out/",
-      "**/build/",
-      "**/.DS_Store",
-      "**/*.pem",
-      "**/npm-debug.log*",
-      "**/yarn-debug.log*",
-      "**/yarn-error.log*",
-      "**/.vercel",
-      "**/.now",
-      "**/.turbo",
-      "**/test-results/",
-      "**/playwright-report/",
-    ],
-  },
   {
     settings: {
       "import/resolver": {

diff --git a/apps/codeforafrica/eslint.config.js b/apps/codeforafrica/eslint.config.js
@@ -1,29 +1,6 @@
 const eslintConfig = require("eslint-config-commons-ui/next");
 
 module.exports = [
-  {
-    ignores: [
-      "**/node_modules",
-      "**/.pnp",
-      "**/.pnp.js",
-      "**/.pnpm-debug.log",
-      "**/dist/",
-      "**/coverage",
-      "**/.next/",
-      "**/out/",
-      "**/build/",
-      "**/.DS_Store",
-      "**/*.pem",
-      "**/npm-debug.log*",
-      "**/yarn-debug.log*",
-      "**/yarn-error.log*",
-      "**/.vercel",
-      "**/.now",
-      "**/.turbo",
-      "**/test-results/",
-      "**/playwright-report/",
-    ],
-  },
   {
     settings: {
       "import/resolver": {

diff --git a/apps/pesayetu/eslint.config.js b/apps/pesayetu/eslint.config.js
@@ -1,29 +1,6 @@
 const eslintConfig = require("eslint-config-commons-ui/next");
 
 module.exports = [
-  {
-    ignores: [
-      "**/node_modules",
-      "**/.pnp",
-      "**/.pnp.js",
-      "**/.pnpm-debug.log",
-      "**/dist/",
-      "**/coverage",
-      "**/.next/",
-      "**/out/",
-      "**/build/",
-      "**/.DS_Store",
-      "**/*.pem",
-      "**/npm-debug.log*",
-      "**/yarn-debug.log*",
-      "**/yarn-error.log*",
-      "**/.vercel",
-      "**/.now",
-      "**/.turbo",
-      "**/test-results/",
-      "**/playwright-report/",
-    ],
-  },
   ...eslintConfig,
   {
     settings: {

diff --git a/apps/promisetracker/eslint.config.js b/apps/promisetracker/eslint.config.js
@@ -1,29 +1,6 @@
 const eslintConfig = require("eslint-config-commons-ui/next");
 
 module.exports = [
-  {
-    ignores: [
-      "**/node_modules",
-      "**/.pnp",
-      "**/.pnp.js",
-      "**/.pnpm-debug.log",
-      "**/dist/",
-      "**/coverage",
-      "**/.next/",
-      "**/out/",
-      "**/build/",
-      "**/.DS_Store",
-      "**/*.pem",
-      "**/npm-debug.log*",
-      "**/yarn-debug.log*",
-      "**/yarn-error.log*",
-      "**/.vercel",
-      "**/.now",
-      "**/.turbo",
-      "**/test-results/",
-      "**/playwright-report/",
-    ],
-  },
   {
     settings: {
       "import/resolver": {

diff --git a/apps/promisetracker/src/lib/wp/index.js b/apps/promisetracker/src/lib/wp/index.js
@@ -184,7 +184,7 @@ function wp(site) {
       return undefined;
     }
 
-    // eslint-disable-next-line no-underscore-dangle
+    /* eslint  no-underscore-dangle: off */
     const embedded = resource._embedded;
 
     const post = {

diff --git a/apps/promisetracker/src/utils/index.js b/apps/promisetracker/src/utils/index.js
@@ -20,7 +20,7 @@ export function slugify(string) {
 export function groupPromisesByStatus(promises) {
   return {
     count: promises.length,
-    /* eslint-disable no-param-reassign */
+    /* eslint no-param-reassign: "off" */
     statusHistory: promises.reduce((promiseByStatus, promise) => {
       (promiseByStatus[promise.status.title] =
         promiseByStatus[promise.status.title] || []).push(promise);

diff --git a/apps/roboshield/eslint.config.js b/apps/roboshield/eslint.config.js
@@ -1,28 +1,6 @@
 const eslintConfig = require("eslint-config-commons-ui/next");
 
 module.exports = [
-  {
-    ignores: [
-      "**/node_modules",
-      "**/.pnp",
-      "**/.pnp.js",
-      "**/.pnpm-debug.log",
-      "**/coverage",
-      "**/.next/",
-      "**/out/",
-      "**/build",
-      "**/.DS_Store",
-      "**/*.pem",
-      "**/npm-debug.log*",
-      "**/yarn-debug.log*",
-      "**/yarn-error.log*",
-      "**/.vercel",
-      "**/.now",
-      "**/.turbo",
-      "**/contrib/",
-      "**/dist/",
-    ],
-  },
   {
     settings: {
       "import/resolver": {

diff --git a/apps/techlabblog/eslint.config.js b/apps/techlabblog/eslint.config.js
@@ -2,40 +2,31 @@ const eslintConfig = require("eslint-config-commons-ui/next");
 
 module.exports = [
   {
-    ignores: [
-      "**/node_modules",
-      "**/.pnp",
-      "**/.pnp.js",
-      "**/.pnpm-debug.log",
-      "**/dist/",
-      "**/coverage",
-      "**/.next/",
-      "**/out/",
-      "**/build/",
-      "**/.DS_Store",
-      "**/*.pem",
-      "**/npm-debug.log*",
-      "**/yarn-debug.log*",
-      "**/yarn-error.log*",
-      "**/.vercel",
-      "**/.now",
-      "**/.turbo",
-      "**/test-results/",
-      "**/playwright-report/",
-    ],
-  },
-  ...eslintConfig.map((config) => {
-    return {
-      ...config,
-      settings: {
-        ...config.settings,
-        "import/resolver": {
-          typescript: {
-            alwaysTryTypes: false,
-            project: "./tsconfig.json",
-          },
+    settings: {
+      "import/resolver": {
+        webpack: {
+          config: "./eslint.webpack.config.js",
+        },
+        typescript: {
+          alwaysTryTypes: false,
+          project: "./tsconfig.json",
         },
       },
-    };
-  }),
+    },
+  },
+  ...eslintConfig,
+  {
+    rules: {
+      "react/jsx-filename-extension": [1, { extensions: [".js", ".tsx"] }], // This rule allows JSX syntax in both .js and tsx files
+      // Disable requirement for importing file extensions for js and tsx files, without this we cant import custom components in Payload
+      "import/extensions": [
+        "error",
+        "ignorePackages",
+        {
+          js: "never",
+          tsx: "never",
+        },
+      ],
+    },
+  },
 ];
diff --git a/apps/uibook/eslint.config.js b/apps/uibook/eslint.config.js
@@ -1,29 +1,6 @@
 const eslintConfig = require("eslint-config-commons-ui/next");
 
 module.exports = [
-  {
-    ignores: [
-      "**/node_modules",
-      "**/.pnp",
-      "**/.pnp.js",
-      "**/.pnpm-debug.log",
-      "**/dist/",
-      "**/coverage",
-      "**/.next/",
-      "**/out/",
-      "**/build/",
-      "**/.DS_Store",
-      "**/*.pem",
-      "**/npm-debug.log*",
-      "**/yarn-debug.log*",
-      "**/yarn-error.log*",
-      "**/.vercel",
-      "**/.now",
-      "**/.turbo",
-      "**/test-results/",
-      "**/playwright-report/",
-    ],
-  },
   ...eslintConfig,
   {
     settings: {