CKAN 2.10 replace controllers & IRoutes with blueprints #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kilemensi
reviewed
Mar 25, 2024
| @@ -23,15 +23,16 @@ | |||
|
|
|||
| import ckan.plugins as plugins | |||
| import ckan.plugins.toolkit as toolkit | |||
| from . import blueprint | |||
Comment on lines
+33
to
+35
| plugins.implements(plugins.IConfigurer, inherit=True) | ||
| plugins.implements(plugins.ITemplateHelpers, inherit=True) | ||
| plugins.implements(plugins.IBlueprint) |
There was a problem hiding this comment.
Why do some plugins use inherit and others don't? (This is for just my understanding).
There was a problem hiding this comment.
On the blueprint, we only need custom routes to handle our /about/<>/ urls hence though it was not necessary to extend CKAN core's Blueprints. On the other plugins, we inherit helper functions & configurations such as url_for, link_for et.al from CKAN core
koechkevin
approved these changes
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migration of all the controllers to flask views/blueprints. This means changing all BaseController controllers handled by the IRoutes interface to blueprints handled by IBlueprint interface.
IRoutes is deprecates in CKAN < 2.10